New issue
Advanced search Search tips

Issue 715620 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 715713



Sign in to add a comment

Implement transient page loading progress indicator in VrShell

Project Member Reported by cjgrant@chromium.org, Apr 26 2017

Issue description

Plumbing for load progress is available, and was used in the HTML UI.

This bug tracks the skia-based rendering of progress on the URL bar texture.
 
Labels: hotlist-initial-vr-browser
Labels: -hotlist-initial-vr-browser
Blocking: 715713
Owner: cjgrant@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a7558705385f6bcfa8fa31e1466733cd97725dd

commit 2a7558705385f6bcfa8fa31e1466733cd97725dd
Author: cjgrant <cjgrant@chromium.org>
Date: Sat May 13 19:30:21 2017

VR: Add a loading indicator to the scene.

- Report loading state transiently, if loading is in progress.  The
  element disappears shortly after loading completes.
- Prevent elements from attempt to draw themselves before
  Initialization.

BUG= 715620 

Review-Url: https://codereview.chromium.org/2877133002
Cr-Commit-Position: refs/heads/master@{#471602}

[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc
[add] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/textures/loading_indicator_texture.h
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/textures/ui_texture.h
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[add] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_elements/loading_indicator.cc
[add] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_elements/loading_indicator.h
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_elements/textured_element.cc
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_elements/textured_element.h
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_elements/ui_element.cc
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_elements/ui_element.h
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/2a7558705385f6bcfa8fa31e1466733cd97725dd/chrome/browser/android/vr_shell/vr_gl_thread.h

Status: Fixed (was: Assigned)
Summary: Implement transient page loading progress indicator in VrShell (was: Implement page loading progress indicator on read-only VR URL bar)
For reference, the progress indicator is now a separate element.

Sign in to add a comment