New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715615 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocking:
issue 713317



Sign in to add a comment

Enterprise device managed by text is poorly aligned in system tray menu

Project Member Reported by jamescook@chromium.org, Apr 26 2017

Issue description

Chrome ToT r467326, so R60. Not present in R57 stable.

The text looks too high in the item. Maybe this is due to the icon, or top padding, or both.

Code is in tray_enterprise.cc if that matters. It might be a generic LabelTrayView issue also.

To tdanderson for triage.

 
enterprise-managed-tray-too-high.png
46.0 KB View Download
Labels: Proj-MaterialDesign-CrOS
Status: Started (was: Assigned)
CL: https://codereview.chromium.org/2844933003
Blocking: 713317
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8ef156d997fe415dfb94b4917a2a6ed648d626b

commit f8ef156d997fe415dfb94b4917a2a6ed648d626b
Author: tdanderson <tdanderson@chromium.org>
Date: Fri Apr 28 01:47:47 2017

[Ash] Disallow calling HoverHighlightView::SetSubText() with an empty string

SetSubText() in HoverHighlight view should not be called
if the parameter string is empty, otherwise multi-line
rows in the system menu will have the incorrect layout
of their primary text.

BUG= 715615 
TEST=manual

Review-Url: https://codereview.chromium.org/2844933003
Cr-Commit-Position: refs/heads/master@{#467813}

[modify] https://crrev.com/f8ef156d997fe415dfb94b4917a2a6ed648d626b/ash/system/tray/hover_highlight_view.cc
[modify] https://crrev.com/f8ef156d997fe415dfb94b4917a2a6ed648d626b/ash/system/tray/hover_highlight_view.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Chrome OS 9532.0.0, 60.0.3092.0

Sign in to add a comment