VR: Disable request for new permission popup |
|||||||||||||
Issue descriptionFor now, Chrome shouldn't ask for new permissions inside of VR. All permission request should be denied by default.
,
Apr 26 2017
,
Apr 26 2017
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/993ce4c39431965123b7b3d9b088a3c08491d846 commit 993ce4c39431965123b7b3d9b088a3c08491d846 Author: asimjour <asimjour@chromium.org> Date: Wed May 17 22:12:27 2017 Use VrTabHelper to disable media permission and bluetooth picker Disable media permission and bluetooth picker when in VR mode. BUG= 715613 Review-Url: https://codereview.chromium.org/2886163003 Cr-Commit-Position: refs/heads/master@{#472584} [modify] https://crrev.com/993ce4c39431965123b7b3d9b088a3c08491d846/chrome/browser/android/tab_web_contents_delegate_android.cc
,
Jun 6 2017
Is this fixed?
,
Jun 6 2017
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef246e190183ebadebd89dd7e88370231f8d49be commit ef246e190183ebadebd89dd7e88370231f8d49be Author: asimjour <asimjour@chromium.org> Date: Thu Jun 08 15:14:20 2017 Disable permissions dialog in VR When in VR, permission request will be disabled so the user will not be able to give new permissions. BUG= 715613 Review-Url: https://codereview.chromium.org/2904623002 Cr-Commit-Position: refs/heads/master@{#477972} [modify] https://crrev.com/ef246e190183ebadebd89dd7e88370231f8d49be/chrome/browser/android/vr_shell/vr_tab_helper.cc [modify] https://crrev.com/ef246e190183ebadebd89dd7e88370231f8d49be/chrome/browser/permissions/permission_manager.cc [modify] https://crrev.com/ef246e190183ebadebd89dd7e88370231f8d49be/chrome/browser/permissions/permission_manager_unittest.cc
,
Jun 8 2017
,
Jun 8 2017
The latest CL Review-Url: https://codereview.chromium.org/2904623002 needs to be merged back to M60 to stop Chrome from exiting VR when there is a new request for permission. To avoid security issues, Chrome will deny permission requests in VR.
,
Jun 8 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2017
Issue 728274 has been merged into this issue.
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3c39a79f71c6e079af5786a672162ccd5a3303e commit f3c39a79f71c6e079af5786a672162ccd5a3303e Author: Amirhossein Simjour <asimjour@chromium.org> Date: Thu Jun 08 18:36:40 2017 Disable permissions dialog in VR When in VR, permission request will be disabled so the user will not be able to give new permissions. BUG= 715613 (cherry picked from commit b30c2b98a02322dcd366783977b3bc3fc7554ea1) Review-Url: https://codereview.chromium.org/2931943002 . Cr-Commit-Position: refs/branch-heads/3112@{#260} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/f3c39a79f71c6e079af5786a672162ccd5a3303e/chrome/browser/android/vr_shell/vr_tab_helper.cc [modify] https://crrev.com/f3c39a79f71c6e079af5786a672162ccd5a3303e/chrome/browser/permissions/permission_manager.cc [modify] https://crrev.com/f3c39a79f71c6e079af5786a672162ccd5a3303e/chrome/browser/permissions/permission_manager_unittest.cc
,
Jun 21 2017
verified fixed in 61.0.3135.0
,
Jun 21 2017
,
Jun 21 2017
In 61.0.3137.0, clicking on "Auto Download" from https://permission.site brings up a permission popup dialog. so maybe this has resurfaced somehow? VRCore: 1.6.157511470
,
Jun 22 2017
Re-closing this. Tracking #15 in bug 728274 |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by asimjour@chromium.org
, Apr 26 2017