New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715613 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 688122



Sign in to add a comment

VR: Disable request for new permission popup

Project Member Reported by asimjour@chromium.org, Apr 26 2017

Issue description

For now, Chrome shouldn't ask for new permissions inside of VR. All permission request should be denied by default.

 
Blocking: 688122
Labels: hotlist-initial-vr-browser
Labels: -hotlist-initial-vr-browser
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/993ce4c39431965123b7b3d9b088a3c08491d846

commit 993ce4c39431965123b7b3d9b088a3c08491d846
Author: asimjour <asimjour@chromium.org>
Date: Wed May 17 22:12:27 2017

Use VrTabHelper to disable media permission and bluetooth picker

Disable media permission and bluetooth picker when in VR mode.

BUG= 715613 

Review-Url: https://codereview.chromium.org/2886163003
Cr-Commit-Position: refs/heads/master@{#472584}

[modify] https://crrev.com/993ce4c39431965123b7b3d9b088a3c08491d846/chrome/browser/android/tab_web_contents_delegate_android.cc

Labels: M-60
Is this fixed?
Components: UI>Browser>VR
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2017

Status: Fixed (was: Assigned)
Labels: Merge-Request-60
The latest CL
Review-Url: https://codereview.chromium.org/2904623002
needs to be merged back to M60 to stop Chrome from exiting VR when there is a new request for permission. To avoid security issues, Chrome will deny permission requests in VR.
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 8 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: asimjour@chromium.org vollick@chromium.org
Issue 728274 has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 8 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3c39a79f71c6e079af5786a672162ccd5a3303e

commit f3c39a79f71c6e079af5786a672162ccd5a3303e
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Thu Jun 08 18:36:40 2017

Disable permissions dialog in VR

When in VR, permission request will be disabled so the user will
not be able to give new permissions.

BUG= 715613 

(cherry picked from commit b30c2b98a02322dcd366783977b3bc3fc7554ea1)

Review-Url: https://codereview.chromium.org/2931943002 .
Cr-Commit-Position: refs/branch-heads/3112@{#260}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/f3c39a79f71c6e079af5786a672162ccd5a3303e/chrome/browser/android/vr_shell/vr_tab_helper.cc
[modify] https://crrev.com/f3c39a79f71c6e079af5786a672162ccd5a3303e/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/f3c39a79f71c6e079af5786a672162ccd5a3303e/chrome/browser/permissions/permission_manager_unittest.cc

verified fixed in 61.0.3135.0
Status: Verified (was: Fixed)
Status: Assigned (was: Verified)
In 61.0.3137.0, clicking on "Auto Download" from https://permission.site brings up a permission popup dialog. so maybe this has resurfaced somehow?

VRCore: 1.6.157511470
Status: Fixed (was: Assigned)
Re-closing this. Tracking #15 in bug 728274

Sign in to add a comment