New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715600 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 688122



Sign in to add a comment

VR: Disable color chooser

Project Member Reported by asimjour@chromium.org, Apr 26 2017

Issue description

For the first step, all UI widgets should be disabled in VR.
 
Blocking: 688122
Labels: hotlist-initial-vr-browser
Labels: -hotlist-initial-vr-browser
Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8921b24098caf2612b3e30694ce4250781c2cdca

commit 8921b24098caf2612b3e30694ce4250781c2cdca
Author: vollick <vollick@chromium.org>
Date: Thu May 25 02:48:15 2017

Disable color/date chooser in VR mode via WebPreferences

On Android, the color and date time choosers overlay the main
content and are monocular. This is disruptive in VR. Until these
are supported in VR, they will be suppressed.

It's important to note that this suppression preference can change
multiple times in the lifetime of a renderer, so a runtime
enabled feature isn't appropriate. It also means that walking
the DOM each time the preference changes to disable form elements
is also an unattractive option.

BUG= 715600 

Review-Url: https://codereview.chromium.org/2885033007
Cr-Commit-Position: refs/heads/master@{#474534}

[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/chrome/browser/android/vr_shell/vr_tab_helper.cc
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/chrome/browser/android/vr_shell/vr_tab_helper.h
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/content/public/common/web_preferences.cc
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/content/public/common/web_preferences.h
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/content/renderer/render_view_impl.cc
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/third_party/WebKit/Source/core/html/forms/ColorChooserClient.h
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/third_party/WebKit/Source/core/html/forms/DateTimeChooserClient.h
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/third_party/WebKit/Source/web/WebSettingsImpl.cpp
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/third_party/WebKit/Source/web/WebSettingsImpl.h
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/8921b24098caf2612b3e30694ce4250781c2cdca/third_party/WebKit/public/web/WebSettings.h

Status: Fixed (was: Assigned)
Components: UI>Browser>VR
Labels: M-60
Status: Verified (was: Fixed)
Verified in Chrome Canary 61.0.3123.0

Sign in to add a comment