New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715594 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

EasyUnlockServiceSigninChromeos incorrectly tries to Base64 decode a raw string

Project Member Reported by hansberry@chromium.org, Apr 26 2017

Issue description

See right here: https://cs.chromium.org/chromium/src/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc?q=easy_unlock_service_signin_chr+package:%5Echromium$&l=440

The |challenge| property of EasyUnlockDeviceKeyData is not Base64 encoded; it seems to already be a raw string. 

Unfortunately I can't easily provide a patch for this bug because once I change the code to directly use device.challenge, EasyUnlock crash loops on the lock screen.
 

Comment 1 by tengs@chromium.org, May 11 2017

Hey Ryan, I found this bug as well =O

It should be fixed with https://codereview.chromium.org/2863533003/

Comment 2 by tengs@chromium.org, May 11 2017

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fdb40570e2c40ffa318f0131b5cbee4900b964f

commit 4fdb40570e2c40ffa318f0131b5cbee4900b964f
Author: tengs <tengs@chromium.org>
Date: Fri May 19 22:09:36 2017

[EasyUnlock] Serialize and store BeaconSeeds as part of the cryptohome key metadata.

For the login flow, we need to be able to use the same BeaconSeeds as those
in the user preferences.

The BeaconSeeds are refreshed everytime the user logs in or unlocks their
Chromebook like the other EasyUnlock metadata.

BUG= 715594 

Review-Url: https://codereview.chromium.org/2863533003
Cr-Commit-Position: refs/heads/master@{#473352}

[modify] https://crrev.com/4fdb40570e2c40ffa318f0131b5cbee4900b964f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc
[modify] https://crrev.com/4fdb40570e2c40ffa318f0131b5cbee4900b964f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc
[modify] https://crrev.com/4fdb40570e2c40ffa318f0131b5cbee4900b964f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc
[modify] https://crrev.com/4fdb40570e2c40ffa318f0131b5cbee4900b964f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_types.cc
[modify] https://crrev.com/4fdb40570e2c40ffa318f0131b5cbee4900b964f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_types.h
[modify] https://crrev.com/4fdb40570e2c40ffa318f0131b5cbee4900b964f/chrome/browser/signin/chrome_proximity_auth_client.cc
[modify] https://crrev.com/4fdb40570e2c40ffa318f0131b5cbee4900b964f/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/4fdb40570e2c40ffa318f0131b5cbee4900b964f/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc

Comment 4 by tengs@chromium.org, May 20 2017

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment