New issue
Advanced search Search tips

Issue 715554 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Implement native VR UI navigation buttons

Project Member Reported by cjgrant@chromium.org, Apr 26 2017

Issue description

The native/skia browser needs buttons for basic navigation.  This entails:

- Using rendering code to map controller state to UI elements
- Issuing callbacks to UI elements for hover and click-related input
- Creating GL textures for the buttons
- Ensuring that hit-testing works for non-rectangular buttons, if applicable

The final appearance of the button may change to allow incorporation with the URL bar.  That work is considered to be tracked by URL bar work if applicable.

 
Description: Show this description
Update:  The current UX spec for v0 requires only a Back button (no refresh or forward).
Labels: Proj-VR
Labels: -Proj-VR Proj-VR-Shell
Labels: hotlist-initial-vr-browser
Labels: -hotlist-initial-vr-browser
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/730e3cee9100751b3fb33c40f58c68e246e483be

commit 730e3cee9100751b3fb33c40f58c68e246e483be
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Apr 27 14:57:50 2017

VR: Route hover and click events to UI elements.

This change maps VR controller input to non-content UI elements. The
content element is treated separately, so that it can handle scrolling
and fling-type input (these are currently not useful to other elements).

BUG= 715554 

Review-Url: https://codereview.chromium.org/2840183003
Cr-Commit-Position: refs/heads/master@{#467673}

[modify] https://crrev.com/730e3cee9100751b3fb33c40f58c68e246e483be/chrome/browser/android/vr_shell/ui_elements/ui_element.cc
[modify] https://crrev.com/730e3cee9100751b3fb33c40f58c68e246e483be/chrome/browser/android/vr_shell/ui_elements/ui_element.h
[modify] https://crrev.com/730e3cee9100751b3fb33c40f58c68e246e483be/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/730e3cee9100751b3fb33c40f58c68e246e483be/chrome/browser/android/vr_shell/vr_shell_gl.h

Status: Started (was: Assigned)
Status: Fixed (was: Started)
This seems fixed. Please reopen if I've got that wrong.

Sign in to add a comment