New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715543 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Blackboxed script is still breakpointing on promise rejection

Reported by austin.f...@gmail.com, Apr 26 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36

Steps to reproduce the problem:
1. Blackbox a script
2. Make script reject a promise

What is the expected behavior?
Exception breakpoint not to trigger

What went wrong?
Exception breakpoint triggered

Did this work before? N/A 

Chrome version: 58.0.3029.81  Channel: stable
OS Version: OS X 10.11.1
Flash Version: 

The script in question in this instance was:
chrome-extension://kbfnbcaeplbcioakkpcpgfkobkghlhen/src/js/bundle.js
 
blackboxed-breakpoint.png
102 KB View Download
Cc: rbasuvula@chromium.org
Labels: Needs-Feedback
@Reporter: Could you please provide us any sample html/JS file to triage the issue from test team end.

Thank You!
I am not sure I can.  It is a chrome extension script that it is happening in, as mentioned in my initial report.

The extension in question (according to google) is

https://chrome.google.com/webstore/detail/grammarly-for-chrome/kbfnbcaeplbcioakkpcpgfkobkghlhen?hl=en

Perhaps installing that extension will provide you with a reproducible case.
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 27 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 Deleted

Comment 5 by beiju...@gmail.com, Apr 27 2017

I'm seeing this too. In addition to blackboxing the script, I can set the whole line to "Never pause here" and it still happens, and I can also set the mid-line breakpoint handles to "Never pause here" and it still happens. Tested all 4 combinations of blackboxing and "Never pause here" on the line with the rejection. 

Sample (extremely simple) HTML and JS files attached, along with screenshots. 

Using Chrome Version 58.0.3029.81 (64-bit) and macOS Sierra 10.12.4 (16E195)

problem.html
68 bytes View Download
problem.js
152 bytes View Download
Screen Shot 2017-04-27 at 6.26.14 PM.png
81.0 KB View Download
Screen Shot 2017-04-27 at 6.29.42 PM.png
84.8 KB View Download
Labels: Needs-Triage-M58
Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tested the issue by using the sample .html and .js file from comment #5 on Mac 10.12.4 using chrome reported version #58.0.3029.81.

Attached a screencast for reference.

Following are the steps followed to reproduce the issue.
------------
1. Opened the problem.html file in chrome.
2. Blackboxed problem.js script.
3. Made script reject a promise.
4. Did not observe an exception breakpoint getting trigger as expected.

austin.france@ - Could you please verify the screencast and please let us know if anything missed from our side.
If possible please provide a screencast of expected behaviour. 

Thanks...!!
715543.mp4
1.8 MB View Download
I don't follow.  Your screencast seems to demonstrate the problem (Paused on exception Test in a blackboxed script) which seems to contradict your item 4.
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 28 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Recording of it breakpointing when blackboxed
Recording #1.mp4
188 KB View Download
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Unconfirmed)
I believe this is a conscious decision to break on errors (and promise rejections) as long as at least one frame is not blackboxed. Alexey?
First of all, big thanks for sample page and screencast - it helps a lot.

I think it's bug in M58 and it has two parts:
- first of all we should not break on this Promise.reject without "Pause On Caught Exceptions" at all since this promise rejection is caught.
- even if we consider this rejection as uncaiught - all frames in current stack trace are blackboxed and we should ignore any kind of exception breakpoint.

And I can confirm that in beta and canary everything works as expected for me.

@austin.france, could you confirm that in Canary [1] issue is not reproducible?

[1] https://www.google.com/chrome/browser/canary.html
I can't reproduce the problem in Canary (60.0.3083.0)
thanks!

I'll double check with what commit this issue was fixed but I'm worried that this issue is not big enough to be approved for merge into stable. Current beta will become stable ~Jun 6th.
Status: Fixed (was: Assigned)

Sign in to add a comment