New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715535 link

Starred by 1 user
Status: Fixed
Owner:
█ robhogan@chromium.org
Use other robhogan account instead.
Closed: May 2017
Cc:
nyerramilli@chromium.org
█ brajkumar@chromium.org
█ bzbar...@mit.edu
█ msrchandra@chromium.org
█ robho...@gmail.com
█ ranjitkan@chromium.org
aboxhall@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Regression: Unwanted 'Sign Out' text is seen at top L.H.S after clicking on Sign out button at gmail.com

Reported by sans...@etouch.net, Apr 26 2017 
Chrome Version: 60.0.3080.5 983263d7309ff4e4e9c641874f1e9e0909cdecb3-refs/branch-heads/3080@{#6}-32/64 bit
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

Steps:
1. Freshly launch Chrome and sign in to gmail with valid credential
2. Now click on Sign out button and observe at top L.H.S of page

Actual: Unwanted 'Sign Out' text is seen at top L.H.S of page after clicking on Sign out button

Expected: No such 'Sign Out' text should be seen at top L.H.S of page after clicking on Sign out button

This is a regression issue broken in M-60, will soon update the bisect info

Good build: 60.0.3078.0 
Bad build: 60.0.3079.0
Actual_video.mov
4.9 MB Download
Expected_video.mov
2.7 MB Download

Comment 1 by sans...@etouch.net, Apr 26 2017

Components: UI

Comment 2 by ranjitkan@chromium.org, Apr 26 2017

Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)

Comment 3 by brajkumar@chromium.org, Apr 26 2017

Cc: brajkumar@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: dougt@chromium.org
Status: Assigned (was: Untriaged)
Using per revision bisect providing bisect information below

Bisect Information:
--------------------
Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/e0a99ba807c98cb277234bb9ea557549bbf91aa8..0c9b90603321c436e6f892be5435fed84eff857a

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2816273002

dougt@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 4 by chrishtr@chromium.org, Apr 27 2017

Components: -Blink Blink>Accessibility

Comment 5 by dougt@chromium.org, Apr 29 2017

Cc: dmazz...@chromium.org
hrm. that referenced cl should only impact windows.  The code change implements a delegate interface on BrowserAccessibility which should only be called when there is a platform_node_ created:

https://cs.chromium.org/chromium/src/content/browser/accessibility/browser_accessibility.cc?l=69



The regression window does include skia changes and some render changes which I would suspect given the videos:

https://chromium.googlesource.com/chromium/src/+log/60.0.3078.0..60.0.3079.0?pretty=fuller&n=10000


dmazzoni, any ideas?

Comment 6 by dougt@chromium.org, Apr 29 2017 

confirmed that backing out the 2816273002 fixes this.

Comment 7 by dougt@chromium.org, Apr 29 2017 

I stand corrected.

If I delete my profile with:  rm -rf ~/Library/Application\ Support/Chromium/

I can repro this problem with and without the change 2816273002.

Comment 8 by dougt@chromium.org, Apr 30 2017

Cc: -dmazz...@chromium.org robho...@gmail.com
I reproduced the bisection and found a different bad commit.

I started with cd6e6e30dd5709535137c87fa2c22ecb222c89d5 (60.0.3078.0 according to omahaproxy).  From there my process was:

1) mkdir C:\src\chromium\src\xxx
2) .\out\Default\chrome.exe --user-data-dir=c:\src\chromium\src\xxx
3) go to gmail.com
4) login
5) log out and notice any visual changes in the upper left during the log out.
6) delete the xxx directory

Starting with this initial change set, I do see *some* visual dot in the upper left -- possibly a small square image or something -- but there is not text associated with this image/thing.

After the bisection, i found this change set to be the first bad commit:

fe767186a3dc40ea14b5f807ff5438bd78f79c95 is the first bad commit
commit fe767186a3dc40ea14b5f807ff5438bd78f79c95
Author: robhogan <robhogan@gmail.com>
Date:   Sat Apr 22 12:24:41 2017 -0700

    Use a non-replaced inline container for image alt text

    This makes us conform more closely to
    https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element
    and the third bullet point in the spec
    at https://html.spec.whatwg.org/multipage/rendering.html#images-3.

    Our behaviour when it comes to displaying the broken-image icon is still
    not the same as Firefox (we display it more often) but I think we're closer
    to the spec in that regard. Edge doesn't conform to the spec at all.

    TBR=meacer@chromium.org,dmazzoni@chromium.org

    BUG= 644802 

    Review-Url: https://codereview.chromium.org/2593263003
    Cr-Commit-Position: refs/heads/master@{#466546}

:040000 040000 f84f24e73d32a9ad47165df8dee9bab3b58de5f9 a4b7c1942ecd236a41dc9173a32d3d0aaa540a26 M  chrome
:040000 040000 0648842b1b1790890e686cfb9661bed6ce6b2638 edb8ed57ef1f5958cb36a4fc06bfaf03ef468a9f M      content
:040000 040000 71492eb1b5204b9da9806e392dbd915dd06f0c9f 1e4878a3f032d065f5a520d000e47d6c0716ac6e M  third_party


robhogan, can you take a look?

Comment 9 by robhogan@chromium.org, Apr 30 2017

Labels: Needs-Evangelism
Hard to get a snapshot of the 'Please wait..' page but it must be using an image element that has an empty or deliberately invalid src along with the alt text 'Sign Out'. My assumption is that the new behaviour is correct per spec, but it's hard to tell without being able to capture the interstitial. Anyone else able to capture it?

Comment 10 by dougt@chromium.org, Apr 30 2017 

After you log out, the browser is directed to this document:


<html><head><title>Google Accounts</title>
<meta name="robots" content="noindex">
<meta name="viewport" content="width=device-width, initial-scale=1">
<style type="text/css">
    body {font-family: arial,sans-serif;}
    .body {margin: 0 15px; }

    div.errorbox-good {}

    div.errorbox-bad {}

    div.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;}
    font.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;}
  </style>
</head>
<body onload="doRedirect()"><p>Please wait...</p>
<noscript>&lt;meta http-equiv="refresh" content="5; url=&amp;#39;https://mail.google.com/mail&amp;#39;"&gt;</noscript>
<script type="text/javascript">
    

    function doRedirect() {
    
      
        location.replace("https://mail.google.com/mail");
      
    }
  </script>

<img src="https://googleads.g.doubleclick.net/pagead/drt/so?r=-7164043774384153010" height="0" width="0" alt="Sign Out"> <img src="https://mail.google.com/accounts/ClearOSID" height="0" width="0" alt="Sign Out"> <img src="https://notifications.google.com/accounts/ClearOSID" height="0" width="0" alt="Sign Out"></body></html>

Comment 11 by dougt@chromium.org, Apr 30 2017 

reduced test case.

Loading this before the referenced bad CL will display a very small broken image.  After the CL, we will display the alt attribute text.
img_test.html
109 bytes View Download

Comment 12 by robhogan@chromium.org, Apr 30 2017

Cc: bzbar...@mit.edu
<img src="https://mail.google.com/accounts/ClearOSID" height="0" width="0" alt="Sign Out"> hits the following in https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element:

"If the src attribute is set and the alt attribute is set to a value that isn't empty
The image is a key part of the content; the alt attribute gives a textual equivalent or replacement for the image.

If the image is available and the user agent is configured to display that image, then the element represents the element's image data.

Otherwise, the element represents the text given by the alt attribute. User agents may provide the user with a notification that an image is present but has been omitted from the rendering."

So when it fails to load, it then hits this part of https://html.spec.whatwg.org/multipage/rendering.html#images-3:

"If the element is an img element that represents some text and the user agent does not expect this to change
The user agent is expected to treat the element as a non-replaced phrasing element whose content is the text, optionally with an icon indicating that an image is missing, so that the user can request the image be displayed or investigate why it is not rendering. In non-graphical contexts, such an icon should be omitted."

So it looks like the zero dimensions don't affect the rendering expected by the spec. This isn't how Firefox does it though - it doesn't render the alt text. So maybe I'm misreading the spec again, cc'ing Boris who I hope can set me straight.

Comment 13 by bzbar...@mit.edu, Apr 30 2017 

> This isn't how Firefox does it though - it doesn't render the alt text.

The relevant bit of https://html.spec.whatwg.org/multipage/rendering.html#images-3 is the second rule, which says:

"If the element does not represent an image, but the element already has intrinsic dimensions (e.g. from the dimension attributes or CSS rules), and either ... the Document is in quirks mode" etc.

This case applies to the reduced testcase, at least: it's in quirks mode, and the <img> has dimension attributes.  The "intrinsic dimensions" bit is not quite right, because that's not what dimension attributes do; I filed https://github.com/whatwg/html/issues/2609 to get that part fixed in the spec.  But the point is that in quirks mode if both the width and height of an <img> are length, percent, or calc,

Comment 14 by bzbar...@mit.edu, Apr 30 2017 

Oh, and I almost forgot: the reduced testcase is in quirks mode, but is the original gmail page too?

Comment 15 by robhogan@chromium.org, May 1 2017 

Thanks Boris, you're right that our quirks-mode rendering is wrong here.

Comment 16 by dougt@chromium.org, May 1 2017

Owner: robhogan@chromium.org
Status: Available (was: Assigned)
Over to robhogan@chromium.org
Project Member

Comment 17 by bugdroid1@chromium.org, May 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e3e1972ebbfdcbde70ef7c33c98169641e3f335

commit 2e3e1972ebbfdcbde70ef7c33c98169641e3f335
Author: robhogan <robhogan@gmail.com>
Date: Thu May 04 21:35:28 2017

Render 0px broken images correctly in quirks mode

Even if an image is smaller than the broken image icon it still needs to
render as a replaced element per https://html.spec.whatwg.org/multipage/rendering.html#images-3.
So do that, but ensure the broken image icon is hidden and don't render
it with a border or any other decoration.

BUG= 715535 

Review-Url: https://codereview.chromium.org/2853733004
Cr-Commit-Position: refs/heads/master@{#469479}

[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/images/rendering-broken-0px-images-quirk.html
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/images/rendering-broken-0px-images.html
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/css1/box_properties/float_elements_in_series-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/images/rendering-broken-0px-images-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/images/rendering-broken-0px-images-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/images/rendering-broken-0px-images-quirk-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/images/rendering-broken-0px-images-quirk-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/images/rendering-broken-10px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/images/rendering-broken-10px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/images/rendering-broken-16px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/images/rendering-broken-1px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/images/rendering-broken-1px-images-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rendering-broken-0px-images-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rendering-broken-0px-images-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rendering-broken-0px-images-quirk-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rendering-broken-0px-images-quirk-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rendering-broken-10px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rendering-broken-10px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rendering-broken-16px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rendering-broken-1px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rendering-broken-1px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/css1/box_properties/float_elements_in_series-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/rendering-broken-0px-images-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/rendering-broken-0px-images-quirk-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/rendering-broken-10px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/rendering-broken-1px-images-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/images/rendering-broken-0px-images-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/images/rendering-broken-0px-images-quirk-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/images/rendering-broken-10px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/images/rendering-broken-1px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/css1/box_properties/float_elements_in_series-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/images/rendering-broken-0px-images-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/images/rendering-broken-0px-images-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/images/rendering-broken-0px-images-quirk-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/images/rendering-broken-0px-images-quirk-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/images/rendering-broken-10px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/images/rendering-broken-10px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/images/rendering-broken-16px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/images/rendering-broken-1px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/images/rendering-broken-1px-images-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/rendering-broken-0px-images-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/rendering-broken-0px-images-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/rendering-broken-0px-images-quirk-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/rendering-broken-0px-images-quirk-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/rendering-broken-10px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/rendering-broken-10px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/rendering-broken-16px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/rendering-broken-1px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/rendering-broken-1px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/css1/box_properties/float_elements_in_series-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/css1/box_properties/float_elements_in_series-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/images/rendering-broken-0px-images-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/images/rendering-broken-0px-images-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/images/rendering-broken-0px-images-quirk-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/images/rendering-broken-0px-images-quirk-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/images/rendering-broken-10px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/images/rendering-broken-10px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/images/rendering-broken-16px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/images/rendering-broken-1px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/images/rendering-broken-1px-images-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/rendering-broken-0px-images-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/rendering-broken-0px-images-expected.txt
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/rendering-broken-0px-images-quirk-expected.png
[add] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/rendering-broken-0px-images-quirk-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/rendering-broken-10px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/rendering-broken-10px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/rendering-broken-16px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/rendering-broken-1px-images-expected.png
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/rendering-broken-1px-images-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/css1/box_properties/float_elements_in_series-expected.txt
[modify] https://crrev.com/2e3e1972ebbfdcbde70ef7c33c98169641e3f335/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

Comment 18 by sureshkumari@chromium.org, May 11 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3095.5
Tested the issue on Windows-7,Mac-10.12.4 and Linux Ubuntu-14.04 using chrome version 60.0.3095.5 with the steps mentioned in comment#0.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screencast for the same.

Thanks!!
715535.mp4
879 KB View Download

Comment 19 by robhogan@chromium.org, May 20 2017

Status: Fixed (was: Available)
►

Sign in to add a comment