New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715524 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 714976



Sign in to add a comment

Recipe steps should show step input as well

Project Member Reported by machenb...@chromium.org, Apr 26 2017

Issue description

Recipe steps already show output (e.g. json output) in logs. However, it is very hard to reason about inputs.

E.g. I'd like to find out what --swarming-targets-file /tmp/tmp7sofLT is in:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.gpu%2FGPU_Linux_Builder%2F86212%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout

I'd need to read long-winded recipe code to derive those inputs.
 
Blocking: 714976
Marked blocked bug to show impact.
Labels: -Pri-1 Pri-2
Status: WontFix (was: Untriaged)
This would be a change to the recipe expectations; it's not immediately clear what the best way to do this would be. In general I think it will be very spammy so I if we want this we wouldn't want to turn it on all the time.

I think the correct way to do this today I would be to set a "breakpoint" in the code (i.e. `import pdb; pdb.set_trace()`, maybe under some conditional) and then run the debugger (`./recipes.py test debug --filter recipe_name.recipe_test_name`). This would let you use normal pdb debugging techniques for a given simulation.

Going to close this as wontfix (suggestion: use the debugger instead). Please reopen if you think the debugger isn't enough to cover this usecase and we should add additional code to the recipe engine to support it.
Status: Available (was: WontFix)
I tried that first for the issue at hand. This was unfortunately blocked by  issue 715520  as the recipe couldn't run locally.

Furthermore, debugging locally first in order to recalculate the input values of a given step script is substantially harder than just reading the input values from a log.

But I hear you in regards to expectations. Maybe by default, those expectations could be hidden?

Another problem might be the log size. Maybe some input files are very large. If they're exposed to logdog by default, or even buildbot, it might eat some resources. If such a feature existed, maybe it could be used as opt-in, e.g. by providing a parameter to json.input or raw_io.input?
Project Member

Comment 4 by sheriffbot@chromium.org, May 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -phajdan.jr@chromium.org
Status: WontFix (was: Untriaged)
Guess it's wontfix as nobody will work on this. Hope that folks try to write their recipes in ways that are easy to debug, e.g. expose non-trivial inputs explicitly...

Sign in to add a comment