New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715518 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary Text is seen under supervised user name in chrome://md-settings/accounts page

Project Member Reported by mmanchala@chromium.org, Apr 26 2017

Issue description

Chrome Version: 58.0.3029.87/9334.57.0 beta channel Daisy,Candy,Peppy Minnie and Quawks.
OS: Chrome

Pre-Condition : Create/import Supervised user

What steps will reproduce the problem?
(1)Sign in to user -> Go to chrome://md-settings/accounts page
(2)In 'Manage Other users' page under 'Restrict sign-in to the following users' observe unnecessary text under Supervised name (Please refer screenshot)

Expected: Only Supervised name should be seen
Actual: Instead unnecessary text is seen

Note : Issue is also seen in latest M-60.

This is Regression Issue as same is working fine in chrome://settings

@stevenjb : Please confirm the Issue
 
Actual.jpg
66.6 KB View Download
Expected_Name.jpg
89.2 KB View Download
Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a03ce481e33b012c70d864788a2c18568128d8cc

commit a03ce481e33b012c70d864788a2c18568128d8cc
Author: stevenjb <stevenjb@chromium.org>
Date: Mon May 01 18:29:54 2017

MD Settings: user list fixes

This CL:
* Updates the API code to make better use of user_manager::User.
* Adds an isSUpervised property to usersPrivate::User.
* Hides the email address for supervised users and whitelisted users not on the device (where the name is unknown).
* Adds CrScrollableBehavior to the user list so that top and bottom borders for the list display properly.
* Adds a requestUpdateScroll method to CrScrollableBehavior so that borders are set properly when the list updates (in addition to when it scrolls).

BUG= 715518 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2840313002
Cr-Commit-Position: refs/heads/master@{#468360}

[modify] https://crrev.com/a03ce481e33b012c70d864788a2c18568128d8cc/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/a03ce481e33b012c70d864788a2c18568128d8cc/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/a03ce481e33b012c70d864788a2c18568128d8cc/chrome/browser/resources/settings/people_page/user_list.html
[modify] https://crrev.com/a03ce481e33b012c70d864788a2c18568128d8cc/chrome/browser/resources/settings/people_page/user_list.js
[modify] https://crrev.com/a03ce481e33b012c70d864788a2c18568128d8cc/chrome/common/extensions/api/users_private.idl
[modify] https://crrev.com/a03ce481e33b012c70d864788a2c18568128d8cc/third_party/closure_compiler/externs/users_private.js
[modify] https://crrev.com/a03ce481e33b012c70d864788a2c18568128d8cc/ui/webui/resources/cr_elements/cr_scrollable_behavior.js

Cc: tbuck...@chromium.org
Status: Fixed (was: Started)
Tom, I don't think this is critical to merge to 59? LMKWYT.

Status: Verified (was: Fixed)
9532.0.0, 60.0.3092.0

Sign in to add a comment