Regression: Page transition is not smooth on chrome://settings/content, after changing browser language to RTL.
Reported by
aiman.an...@etouch.net,
Apr 26 2017
|
||||||||||||
Issue descriptionChrome Version:60.0.3080.5 (Official Build) (cohort: win_58_81)983263d7309ff4e4e9c641874f1e9e0909cdecb3-refs/branch-heads/3080@{#6}(32/64 Bit). OS: Windows(7,8,10). Steps to reproduce: 1.Launch Chrome, go to chrome://settings, change browser language to 'Hebrew' from chrome://settings/languages. 2.Relaunch Chrome, go to chrome://settings/content, click on sub page-arrow for cookies. 3.Click on back iron-icon on Cookies sub-page and observe page transition. Actual Result: Page transition is not smooth. Expected Result: Page transition should be smooth. This is regression issue broken in 'M 59' and will soon update the bisect info: Manual Bisect Info: Good Build 59.0.3069.0 Bad Build 59.0.3070.0 Note: Issue is not reproducible on MAC and LINUX OS.
,
Apr 26 2017
,
Apr 27 2017
Using the per-revision bisect providing the bisect results, Good build: 59.0.3069.0 (Revision: 463921). Bad build : 59.0.3070.0 (Revision: 464226). You are probably looking for a change made after 464187 (known good), but no later than 464188 (first known bad). CHANGELOG URL: The script might not always return single CL as suspectas some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/ffcbc0b2bda32309a8e799e146b934ce9b556b82..995b74dc39fedb4f3cdeb67bb32ad3d26ea175ee @mfomitchev: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You.
,
May 1 2017
The bisect CL seems unrelated.
,
May 2 2017
I don't believe my CL is at fault here. InProcessCommandBuffer isn't even used on Windows currently.
,
May 3 2017
Re bisected on a different machine and getting the following suspect. Narrow Bisect Info: https://chromium.googlesource.com/chromium/src/+log/91b3f7e7b1f592052614ffd6eb61d60f87dd2571..2d54317a97881484713af4069f01677e924dc87e?pretty=fuller&n=10000 Suspecting: r464085? @dpapad: Kindly help to re-assign if your change is not the cause for this issue.
,
May 3 2017
,
May 3 2017
My patch added logic that only gets triggered when there is a scroll event. I've double checked that when clicking on the back icon as mentioned in the bug description there is no relevant logic being triggered.
,
May 24 2017
This is not a localization bug. Have confirmed it on English UI
,
Jun 21 2017
Issue 734018 has been merged into this issue.
,
Jun 21 2017
,
Sep 21 2017
,
Sep 21 2017
,
Sep 21 2017
FYI, the fix candidate is at https://chromium-review.googlesource.com/c/chromium/src/+/676383. With this CL the animation (see screencast too): - has the correct direction in both RTL and LTR - is smooth (the glitch when exiting animation is no longer happening).
,
Sep 21 2017
Thank you for getting this fixed so quickly!
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa11fff5aa7f799a3fff9f900d6c43e55b1fabc5 commit fa11fff5aa7f799a3fff9f900d6c43e55b1fabc5 Author: dpapad <dpapad@chromium.org> Date: Fri Sep 22 03:48:12 2017 Settings WebUI: Fix subpage entry/exit animation in RTL mode. Left/right sliding of subpages needs to be reversed in RTL. Bug: 715509 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I58a79b4fc5fa2514b2ea030cff69eaf3256833e2 Reviewed-on: https://chromium-review.googlesource.com/677413 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#503642} [modify] https://crrev.com/fa11fff5aa7f799a3fff9f900d6c43e55b1fabc5/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
,
Sep 22 2017
,
Sep 26 2017
Tested the issue on Windows, Mac & Linux using Chrome Canary# 63.0.3223.8 and could not reproduce the issue. Hence adding TE-Verified for Windows, Mac and Linux. Attached a screen cast for further reference. Thank You. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by aiman.an...@etouch.net
, Apr 26 2017