New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715480 link

Starred by 1 user
Status: Archived
Owner:
█ yhong@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
chromeos-factory-eng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: easy bundle creation: Decide if we should remove HWID from ebuild packages.

Project Member Reported by hungte@chromium.org, Apr 26 2017 
Currently we do build chromeos-hwid package when creating factory.zip. However,
 
 - Partners usually download HWID config bundle from CPFE, where the self-service tool will directly call create_bundle.
 - The easy bundle creation tool may need to always pick the latest HWID config files

As a result, I wonder if we still need to have the chromeos-hwid ebuild, even not having it in the factory.zip (still need to live in bundle anyway).

One motivation for this is, when a HWID config change is merged to old factory branch (like rambi or strago), all boards (more than 20) sharing same branch will try to rebuild - which occupied all branch builder resources and taking few days to complete.

So if we can stop having builds due to HWID changes, maybe it'll be better.

Comment 1 by hungte@chromium.org, Jul 26 2017

Cc: -youcheng@chromium.org -phoenixshen@chromium.org chromeos-factory-eng@google.com
Owner: yhong@chromium.org

Comment 2 by yhong@chromium.org, Aug 14 2017 

After discussing offline, phoenixshen@ and I think chromeos-hwid package is no need to be built into factory.zip since most of the time, the partner will download the HWID bundle from CPFE directly.

Comment 3 by hungte@chromium.org, Aug 14 2017 

feel free to remove the ebuild package and its dependency from source tree.

Comment 4 by hungte@chromium.org, Aug 14 2017 

oh one more thing: I don't know if the "create new (factory) branch" will work properly if we the source repo is not referenced in any ebuild (or manifest). Need to check on that.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/6ad2cda9e679fa351105eab814824d57eae71d46

commit 6ad2cda9e679fa351105eab814824d57eae71d46
Author: Yong Hong <yhong@google.com>
Date: Mon Aug 14 12:54:35 2017

Comment 6 by yhong@chromium.org, Aug 25 2017

Status: Started (was: Untriaged)

Comment 8 by yhong@chromium.org, Aug 25 2017

Status: Fixed (was: Started)
The ebuild for chromeos-hwid is removed.  After double check with bhthompson@, who helps us creating factory branch, we know that src/platform/chromeos-hwid will still fork when a new factory branch is created.

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Project Member

Comment 10 by bugdroid1@chromium.org, May 21 2018

Labels: merge-merged-factory-eve-9667.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/91e4c65fc470607c58fed0ddd02b64e413a73e36

commit 91e4c65fc470607c58fed0ddd02b64e413a73e36
Author: Yong Hong <yhong@chromium.org>
Date: Mon May 21 09:51:20 2018

chromeos-hwid: Remove chromeos-hwid package.

This change removes chromeos-hwid package since we no longer want
to build HWID bundle into factory.zip.

BUG= chromium:715480 
TEST=emerge virtual/target-chromium-os-factory

Change-Id: Ie81f219aa3813aa3d9538200c6ae0c009da959ae
Reviewed-on: https://chromium-review.googlesource.com/620337
Commit-Ready: Yong Hong <yhong@chromium.org>
Tested-by: Yong Hong <yhong@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
(cherry picked from commit 0b3819b062f8f992ceeb77d40e20c858b096d08f)
Reviewed-on: https://chromium-review.googlesource.com/1065838
Commit-Queue: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Trybot-Ready: Yong Hong <yhong@google.com>
Reviewed-by: Yilun Lin <yllin@chromium.org>

[delete] https://crrev.com/9beb0e3f4e0d0c42700910acdf206cdc3d6f6add/chromeos-base/chromeos-hwid/chromeos-hwid-0.0.1-r1.ebuild
[rename] https://crrev.com/91e4c65fc470607c58fed0ddd02b64e413a73e36/virtual/target-chromium-os-factory/target-chromium-os-factory-1-r5.ebuild
[modify] https://crrev.com/91e4c65fc470607c58fed0ddd02b64e413a73e36/virtual/target-chromium-os-factory/target-chromium-os-factory-1.ebuild
[delete] https://crrev.com/9beb0e3f4e0d0c42700910acdf206cdc3d6f6add/chromeos-base/chromeos-hwid/chromeos-hwid-0.0.1.ebuild
►

Sign in to add a comment