Regression: No space between search engine and keyword sections in manage search engines |
||||||||
Issue descriptionChrome Version:60.0.3080.5 OS: Ubuntu 14.04, Windows Extension URL: https://chrome.google.com/webstore/detail/lastpass-free-password-ma/hdokiejnpimakedhajhdlcegeplioahd?hl=en-GB What steps will reproduce the problem? (1)Launch Chrome and navigate to chrome://apps (2)Add above url (3)Navigate to chrome://md-settings and increase font size to very large (4)Go to manage search engines and observe search engine added by extension Expected Result: There should be space between search engine and keyword Actual Result: There is no space between search engine and keyword This is a regression issue broken in M-58 Manual bisect info: =================== Good Build: 58.0.3015.0 Bad Build : 58.0.3016.0
,
Apr 26 2017
Using the per-revision bisect providing the bisect results, Good build: 58.0.3015.0 (Revision: 451180). Bad build : 58.0.3016.0 (Revision: 451403). You are probably looking for a change made after 451189 (known good), but no later than 451190 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/19b6d116165378bc06ae204d74b5b1da58caa9ab..876cafa176fb331cd498c895d6ccbb15f206eb04 @dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You.
,
Apr 27 2017
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52cb55108113396c95ba08d9e40c0ba18f528de3 commit 52cb55108113396c95ba08d9e40c0ba18f528de3 Author: dpapad <dpapad@chromium.org> Date: Fri Apr 28 22:38:21 2017 MD Settings: Tweak omnibox search engine look to match other search engines. BUG= 715466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2839413004 Cr-Commit-Position: refs/heads/master@{#468160} [modify] https://crrev.com/52cb55108113396c95ba08d9e40c0ba18f528de3/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
,
Apr 28 2017
,
Apr 28 2017
,
Apr 29 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91b367fbb4812de0071cd08b35dfff1f88c1e518 commit 91b367fbb4812de0071cd08b35dfff1f88c1e518 Author: Lei Zhang <thestig@chromium.org> Date: Tue May 02 18:36:57 2017 M59: MD Settings: Tweak omnibox search engine look to match other search engines. BUG= 715466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2839413004 Cr-Commit-Position: refs/heads/master@{#468160} (cherry picked from commit 52cb55108113396c95ba08d9e40c0ba18f528de3) Review-Url: https://codereview.chromium.org/2860493002 . Cr-Commit-Position: refs/branch-heads/3071@{#359} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/91b367fbb4812de0071cd08b35dfff1f88c1e518/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
,
May 3 2017
Rechecked this issue on chrome version 59.0.3071.36 on Windows 10, Mac 10.12.4, Ubuntu 14.04. Fix is working as intended. Space is displayed between extension Search engine and Keyword (Screen Shot attached). Adding TE-Verified labels |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kavvaru@chromium.org
, Apr 26 2017Labels: Proj-MaterialDesign-WebUI OS-Mac
Status: Untriaged (was: Unconfirmed)