New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715461 link

Starred by 1 user
Status: Archived
Owner:
hashimoto@chromium.org
Closed: Apr 2017
Cc:
█ dspaid@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 688900



Sign in to add a comment

MigrationHelper::MigrateFile does not persist empty file

Project Member Reported by hashimoto@chromium.org, Apr 26 2017 
MigrationHelper::MigrateFile calls SyncDirectory against the parent directory in a while loop which does nothing for an empty file.
SyncDirectory should be called for empty files too.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/681e9667c5e924d298eea054c91972967a179c87

commit 681e9667c5e924d298eea054c91972967a179c87
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Thu Apr 27 05:13:12 2017

cryptohome: Call SyncDirectory for empty files

BUG= chromium:715461 
TEST=cros_workon_make cryptohome --test

Change-Id: I6d71e7b59e937245d83b6ba2d50b13624cc358e5
Reviewed-on: https://chromium-review.googlesource.com/488001
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Spaid <dspaid@chromium.org>

[modify] https://crrev.com/681e9667c5e924d298eea054c91972967a179c87/cryptohome/dircrypto_data_migrator/migration_helper.cc

Comment 2 by hashimoto@chromium.org, Apr 27 2017

Labels: M-60
Status: Fixed (was: Started)

Comment 3 by hashimoto@chromium.org, May 12 2017

Labels: Merge-Request-59

Comment 4 by gkihumba@google.com, May 12 2017

Labels: Merge-Approved-59
Project Member

Comment 5 by sheriffbot@chromium.org, May 13 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, May 15 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ee5a3a902c2a6a08359dee399476da565b19fbb3

commit ee5a3a902c2a6a08359dee399476da565b19fbb3
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Mon May 15 02:29:40 2017

cryptohome: Call SyncDirectory for empty files

BUG= chromium:715461 
TEST=cros_workon_make cryptohome --test

Change-Id: I6d71e7b59e937245d83b6ba2d50b13624cc358e5
Reviewed-on: https://chromium-review.googlesource.com/488001
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Spaid <dspaid@chromium.org>
(cherry picked from commit 681e9667c5e924d298eea054c91972967a179c87)
Reviewed-on: https://chromium-review.googlesource.com/505968
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>

[modify] https://crrev.com/ee5a3a902c2a6a08359dee399476da565b19fbb3/cryptohome/dircrypto_data_migrator/migration_helper.cc

Comment 7 by hashimoto@chromium.org, May 15 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-59

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment