New issue
Advanced search Search tips

Issue 715459 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Change bad->invalid machine error

Project Member Reported by ljusten@chromium.org, Apr 26 2017

Issue description

Change ERROR_BAD_MACHINE_NAME to ERROR_INVALID_MACHINE_NAME (as soon as it's available) since the meaning has changed (the ID hasn't).
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/795c4f100e123db3775930dd6e170a9b56b12657

commit 795c4f100e123db3775930dd6e170a9b56b12657
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Tue May 23 14:35:08 2017

Chromad: Change ERROR_BAD_MACHINE_NAME to ERROR_INVALID_MACHINE_NAME

BUG= 715459 
TEST=existing tests
TBR=achuith@chromium.org

Change-Id: Ib52ef795f5b7cfab49a0d156679653b00c4c8db9
Reviewed-on: https://chromium-review.googlesource.com/512722
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473888}
[modify] https://crrev.com/795c4f100e123db3775930dd6e170a9b56b12657/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/795c4f100e123db3775930dd6e170a9b56b12657/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/795c4f100e123db3775930dd6e170a9b56b12657/chromeos/dbus/fake_auth_policy_client_unittest.cc

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment