New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715450 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Google Chrome MSI 58.0.3029.81 installs with English UI on new machines

Project Member Reported by pastarmovj@chromium.org, Apr 26 2017

Issue description

We are using non-english system locale and UI lang, and Chrome MSI was installing with OS UI language, all fine. Since version 58, Chrome MSI installs with English UI on non-english OS.

Context: https://productforums.google.com/forum/#!topic/chrome-admins/bjfL_Ccg8ys;context-place=forum/chrome-admins
 

Comment 1 by grt@chromium.org, Apr 26 2017

Cc: blumberg@chromium.org grt@chromium.org
Components: Enterprise
Owner: georgesak@chromium.org
Status: Assigned (was: Untriaged)
The Chrome enterprise installer (.msi) now installs using the language of the download page, matching the behavior of the organic installer. Is this, in fact, not desirable for enterprises? Do we need an escape hatch (i.e., a way to override the lang on the command line), or should we ignore the dlpage language and go back to the way it used to be?

Assigning to a decider. Bounce back to me with a decision and I'll be happy to fix as desired.
I'm not aware of why this change was done, was it purely to match the exe installer?

I think we should have kept status quo, not sure what benefit we get with this change.

Matt, WDYT?
Before we change this back to how it was, I am also curious why this was changed. 

I think in theEnterprise scenario, it makes more sense to match the OS UI language vs the language the admin viewed when downloading the package.


Comment 4 by grt@chromium.org, Apr 28 2017

This came along for the ride with my recent MSI dlpage tag extraction changes. It's easy to back out this one aspect via a change in the MSI wrapper so that it's picked up on the next respin.
I personally vote for reverting to the old behavior then.

...I actually wonder if this should not be the default also for the online installer. Obviously either one can be the right in each situation but maybe at least we can add some UMA how often those doesn't coincide and base an informed decision on this. Combined with the stats how often people change the language from the settings page to the os language - if those are comparable then maybe we are not doing the right thing.

Comment 6 by grt@chromium.org, Apr 28 2017

Cc: -grt@chromium.org georgesak@chromium.org
Owner: grt@chromium.org
We've had bugs filed in the past when the logic was broken for the organic installer. I think it's doing the right thing by obeying the dlpage logic. I would say it's the least surprising thing to read a web page in language L, click a link on it, and continue to be operating in the same language when the Omaha installer pops up and starts downloading Chrome.

I have cl/154530524 out for review to revert the enterprise installer to the prior behavior. My preference would actually be to leave this functionality in the installer, but change the dlpage so that it stops adding "lang=LL" to the tag. That's more work, so let's do the simple thing now to get us back to where we were.

Comment 7 by grt@chromium.org, Apr 28 2017

Status: Started (was: Assigned)

Comment 8 by kotob...@gmail.com, Apr 29 2017

Guys, I'm a topic starter on product forums. Thing is, maybe I'm blind but I can't find a page in Russian to download the Russian msi for chrome... It always was English for me: chrome for work download page. I'd appreciate if you'd revert the change back to what it was in version 57. Thanks! 

Comment 9 by grt@chromium.org, Apr 29 2017

Thanks for the input. The next stable release will have the old behavior once again.
Greg, I think c8 contains another important point - I just checked that https://enterprise.google.com/chrome/chrome-browser/ does not contain language dropdown or something like this so it is not possible to switch the language there. Same is true for the hole site. So if you come with your half-setup default browser  in order to get Chrome you are stuck with whatever guess we made which might not be optimal. 

I think we should consider making it possible to flip the lang of that page so that people can get whichever language they prefer. WDYT? Shoud I open an issue with the page admins?

Comment 11 by grt@chromium.org, May 2 2017

Status: Fixed (was: Started)
Yes, I think it would be nice if the whole enterprise site had a language picker. I'm surprised it doesn't.

Marking this as fixed, as the next stable release will revert back to the old behavior.

Comment 12 by grt@chromium.org, May 2 2017

58.0.3029.96, which contains this fix, is now available from the enterprise download site.

Comment 13 by grt@chromium.org, Dec 4 2017

Cc: kkaluri@chromium.org grt@chromium.org pbomm...@chromium.org
 Issue 728549  has been merged into this issue.

Sign in to add a comment