New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715447 link

Starred by 3 users
Status: Fixed
Owner:
█ ramyasharma@chromium.org
OOO until July 2018
Closed: Jul 2017
Cc:
yyushkina@chromium.org
martis@chromium.org
gambard@chromium.org
napper@chromium.org
jkrcal@chromium.org
█ kennetht@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature



Sign in to add a comment

[LanguageModel] Plug in the model for iOS

Project Member Reported by jkrcal@chromium.org, Apr 26 2017 
LanguageModel currently works only on Android. There are plans to launch content suggestions (that use LanguageModel) on iOS. There are two tasks to be done:
 - create an iOS factory
   (similar to chrome/browser/translate/language_model_factory.cc)
 - feed CLD data to the model
   (similar to https://cs.chromium.org/chromium/src/chrome/browser/translate/chrome_translate_client.cc?l=314)

Comment 1 by jkrcal@chromium.org, Apr 26 2017

Cc: gambard@chromium.org napper@chromium.org kennetht@chromium.org
Does anyone has spare cycles to look into this?

Comment 2 by jkrcal@chromium.org, Apr 26 2017 

(another minor ContentSuggestions-related task is to pass the LanguageModel to RemoteSuggestionsFetcher in ios_chrome_content_suggestions_service_factory)

Comment 3 by gambard@chromium.org, Apr 26 2017 

The factory seems easy, I am not sure I understand what the client is supposed to do.
I am also not sure to understand what the LanguageModel is doing.

Comment 4 by napper@chromium.org, Apr 27 2017

Labels: OS-iOS
Owner: napper@chromium.org
Status: Assigned (was: Available)
We have an iOS engineer who should have some cycles. We will look into this.

Comment 5 by napper@chromium.org, Apr 27 2017

Cc: yyushkina@chromium.org

Comment 6 by napper@chromium.org, Apr 27 2017

Owner: martis@chromium.org

Comment 7 by napper@chromium.org, Apr 27 2017

Cc: ramyasharma@chromium.org

Comment 8 by eugene...@chromium.org, Apr 27 2017

Components: UI>Browser>Language>Translate
Please change the component if Translate is not appropriate

Comment 9 by yyushkina@chromium.org, Apr 27 2017

Components: -UI>Browser>Language>Translate UI>Browser>Language

Comment 10 by martis@chromium.org, May 11 2017

Cc: -ramyasharma@chromium.org martis@chromium.org
Owner: ramyasharma@chromium.org

Comment 11 by ramyasharma@chromium.org, May 29 2017

Status: Started (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8709f78a5a70fd9db4414ca6c0fe281d668f31e5

commit 8709f78a5a70fd9db4414ca6c0fe281d668f31e5
Author: ramyasharma <ramyasharma@chromium.org>
Date: Wed Jun 07 04:26:26 2017

Updates language model on iOS

This cl updates language model on Bling. And clears language model
history on clear browsing data.

This CL does not update language model from
ios/web_view/internal/translate/web_view_translate_client.

Mode details here: https://docs.google.com/document/d/17metf0LUD_p38DhPx7P_lyH9bVvRfuXlVvy91ESZT9M/edit

BUG= 715447 

Review-Url: https://codereview.chromium.org/2913573002
Cr-Commit-Position: refs/heads/master@{#477548}

[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/components/translate/ios/browser/ios_translate_driver.h
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/components/translate/ios/browser/ios_translate_driver.mm
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/components/translate/ios/browser/language_detection_controller.h
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/components/translate/ios/browser/language_detection_controller.mm
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/components/translate/ios/browser/language_detection_controller_unittest.mm
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/ios/chrome/browser/browsing_data/BUILD.gn
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/ios/chrome/browser/translate/chrome_ios_translate_client.mm
[add] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/ios/chrome/browser/translate/language_model_factory.cc
[add] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/ios/chrome/browser/translate/language_model_factory.h
[add] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/ios/chrome/browser/translate/language_model_factory_unittest.cc
[modify] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/ios/web_view/internal/translate/web_view_translate_client.mm

Comment 13 by ramyasharma@chromium.org, Jul 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment