Issue metadata
Sign in to add a comment
|
7.4% regression in memory.desktop at 465472:465520 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 26 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981268581173174736
,
Apr 26 2017
=== Auto-CCing suspected CL author kozyatinskiy@chromium.org === Hi kozyatinskiy@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : kozyatinskiy Commit : 54271c21e2860273abd6018c398b04f672ef2615 Date : Tue Apr 18 20:50:30 2017 Subject: [inspector] move console to builtins Bisect Details Configuration: winx64_10_perf_bisect Benchmark : memory.desktop Metric : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/TrivialWebGLPageSharedPageState Change : 8.13% | 5477717.33333 -> 5922816.0 Revision Result N chromium@465471 5477717 +- 478607 6 good chromium@465478 5565099 +- 605396 6 good chromium@465481 5565099 +- 605396 6 good chromium@465483 5477717 +- 478607 6 good chromium@465483,v8@54271c21e2 5922816 +- 0.0 6 bad <-- chromium@465483,v8@cd76322817 5922816 +- 0.0 6 bad chromium@465484 5922816 +- 0.0 6 bad chromium@465496 5922816 +- 0.0 6 bad chromium@465520 5922816 +- 0.0 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=TrivialWebGLPageSharedPageState memory.desktop Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981268581173174736 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5317708838600704 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 26 2017
The increase is in old space: https://chromeperf.appspot.com/report?sid=ff4221a272c27b877e9228467390f24039ac7237d0e687c194990050d66bee3f
,
Apr 26 2017
looks like metric is restored in latest build - I will check for following build and close it.
,
Apr 28 2017
I tried to reproduce it locally with and without my CL and memory consumption looks pretty stable for V8 part: 3,393.0 KiB vs 3,389.3 KiB and I'm not sure how my change (which just add 20 simple cpp builtin can produce 7% regression),
,
Apr 28 2017
The increase is fairly close to the page size of 512k, so it seems like something is causing an additional old-space page to be allocated (which can be caused by even minor increases in runtime memory if the last available old-space page is filled). If the memory increase from your CL is small, I think it's fine to close this one.
,
May 18 2017
Thanks! It's small - closed for now. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jgruber@chromium.org
, Apr 26 2017