New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715433 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to 'Add a site' after closing incognito window in chrome://md-settings/content/images.

Reported by rp...@etouch.net, Apr 26 2017 
Version: 60.0.3080.5 983263d7309ff4e4e9c641874f1e9e0909cdecb3-refs/branch-heads/3080@{#6}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/content/images
2. Now click on 'Add' button to open 'Add a site' overlay and press 'Ctrl+Shift+N' to open incognito window and minimize it.
3. Now check 'Current incognito session only' check box in 'Add a site' overlay and close the minimized incognito window.
4. Now enter any text in site text field in 'Add a site' overlay and then click on 'Add' button,observe

Actual: Unable to 'Add a site' after closing incognito window
Expected: Should be able to 'Add a site' after closing incognito window

This is regression issue, broken in ‘M 59’ and will soon update other info :
Good build:59.0.3061.0
Bad build: 59.0.3062.0
Actual_video.mp4
762 KB View Download
Expected_video.mp4
771 KB View Download

Comment 1 by rbasuvula@chromium.org, Apr 26 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3061.0 (Revision:461353).
Bad build:59.0.3062.0 (Revision:461587).

You are probably looking for a change made after 461582 (known good), but no later than 461583 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/3423f23e28e4a31463540df78ed3a49b73c873c6..40e5b2648dda4c5f2766de6b34070cc54dd7e96d

From the CL above, assigning the issue to the concern owner

@dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2795873002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #60.0.3080.0.
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83540958fb0ffff1080a759eb3e7b2a06e32902

commit f83540958fb0ffff1080a759eb3e7b2a06e32902
Author: dschuyler <dschuyler@chromium.org>
Date: Tue May 02 19:05:54 2017

[MD settings] clear incognito only checkbox

This CL clears the 'incognito only' checkbox in the add site dialog when
the incognito status changes. A unit test has been added to test this
behavior.

BUG= 715433 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2854753002
Cr-Commit-Position: refs/heads/master@{#468732}

[modify] https://crrev.com/f83540958fb0ffff1080a759eb3e7b2a06e32902/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/f83540958fb0ffff1080a759eb3e7b2a06e32902/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/f83540958fb0ffff1080a759eb3e7b2a06e32902/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

Comment 3 by dschuyler@chromium.org, May 2 2017

Status: Fixed (was: Assigned)

Comment 4 by dbeam@chromium.org, May 2 2017

Labels: -Pri-1 -M-59 M-60 Pri-2

Comment 5 by jmukthavaram@chromium.org, May 4 2017

Labels: TE-Verified-60.0.3088.3 TE-Verified-M60
Tested the issue on windows 7, Mac 10.12.4, Linux Ubuntu 14.04 using chrome version#60.0.3088.3 with the steps mentioned in comment #0.
Observed that user is able to 'Add a site' after closing incognito window. Hence adding TE-Verified labels.

Please find the attached screen cast for the same.

Thanks..!!
715433.mp4
818 KB View Download
►

Sign in to add a comment