New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715396 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

autotest unittest failing on R58 branch

Project Member Reported by bhthompson@google.com, Apr 26 2017

Issue description

https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-pre-flight-branch%20release-R58-9334.B

https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-pre-flight-branch%20release-R58-9334.B/builds/240

autotest-0.0.2-r8002: Running autotest_lib.frontend.afe.models_test
autotest-0.0.2-r8002: test_on_host_membership_change (autotest_lib.frontend.afe.models_test.AclGroupTest) ... ok
autotest-0.0.2-r8002: test_execution_path (autotest_lib.frontend.afe.models_test.HostQueueEntryUnittest) ... ok
autotest-0.0.2-r8002: test_add_host_previous_one_time_host (autotest_lib.frontend.afe.models_test.HostTest) ... ok
autotest-0.0.2-r8002: test_check_board_labels_allowed (autotest_lib.frontend.afe.models_test.HostTest) ... ok
autotest-0.0.2-r8002: test_check_parameterized_jobs_both_args (autotest_lib.frontend.afe.models_test.JobTest) ... ok
autotest-0.0.2-r8002: test_check_parameterized_jobs_disabled (autotest_lib.frontend.afe.models_test.JobTest) ... ok
autotest-0.0.2-r8002: test_check_parameterized_jobs_enabled (autotest_lib.frontend.afe.models_test.JobTest) ... ERROR
autotest-0.0.2-r8002: test_check_parameterized_jobs_no_args (autotest_lib.frontend.afe.models_test.JobTest) ... ok
autotest-0.0.2-r8002: test_create (autotest_lib.frontend.afe.models_test.KernelTest) ... ok
autotest-0.0.2-r8002: test_create_kernels (autotest_lib.frontend.afe.models_test.KernelTest) ... ok
autotest-0.0.2-r8002: test_create_kernels_none (autotest_lib.frontend.afe.models_test.KernelTest) ... ok
autotest-0.0.2-r8002: test_cloned_queryset_delete (autotest_lib.frontend.afe.models_test.ModelWithInvalidTest) ... ok
autotest-0.0.2-r8002: test_model_with_invalid_delete (autotest_lib.frontend.afe.models_test.ModelWithInvalidTest) ... ok
autotest-0.0.2-r8002: test_model_with_invalid_delete_queryset (autotest_lib.frontend.afe.models_test.ModelWithInvalidTest) ... ok
autotest-0.0.2-r8002: test_normal_delete (autotest_lib.frontend.afe.models_test.ModelWithInvalidTest) ... ok
autotest-0.0.2-r8002: test_normal_delete_queryset (autotest_lib.frontend.afe.models_test.ModelWithInvalidTest) ... ok
autotest-0.0.2-r8002: test_job (autotest_lib.frontend.afe.models_test.ParameterizedJobTest) ... ERROR
autotest-0.0.2-r8002: test_response (autotest_lib.frontend.afe.models_test.SerializationTest) ... ok
autotest-0.0.2-r8002: test_sync_aborted (autotest_lib.frontend.afe.models_test.SerializationTest) ... ok
autotest-0.0.2-r8002: test_update (autotest_lib.frontend.afe.models_test.SerializationTest) ... ok
autotest-0.0.2-r8002: test_activate (autotest_lib.frontend.afe.models_test.SpecialTaskUnittest) ... ok
autotest-0.0.2-r8002: test_execution_path (autotest_lib.frontend.afe.models_test.SpecialTaskUnittest) ... ok
autotest-0.0.2-r8002: test_finish (autotest_lib.frontend.afe.models_test.SpecialTaskUnittest) ... ok
autotest-0.0.2-r8002: test_requested_by_from_queue_entry (autotest_lib.frontend.afe.models_test.SpecialTaskUnittest) ... ok
autotest-0.0.2-r8002: test_status (autotest_lib.frontend.afe.models_test.SpecialTaskUnittest) ... ok
autotest-0.0.2-r8002: 
autotest-0.0.2-r8002: ======================================================================
autotest-0.0.2-r8002: ERROR: test_check_parameterized_jobs_enabled (autotest_lib.frontend.afe.models_test.JobTest)
autotest-0.0.2-r8002: ----------------------------------------------------------------------
autotest-0.0.2-r8002: Traceback (most recent call last):
autotest-0.0.2-r8002:   File "/build/samus/tmp/portage/chromeos-base/autotest-0.0.2-r8002/work/autotest-0.0.2/frontend/afe/models_test.py", line 313, in test_check_parameterized_jobs_enabled
autotest-0.0.2-r8002:     global_config.global_config.override_config_value(
autotest-0.0.2-r8002: NameError: global name 'global_config' is not defined
autotest-0.0.2-r8002: 
autotest-0.0.2-r8002: ======================================================================
autotest-0.0.2-r8002: ERROR: test_job (autotest_lib.frontend.afe.models_test.ParameterizedJobTest)
autotest-0.0.2-r8002: ----------------------------------------------------------------------
autotest-0.0.2-r8002: Traceback (most recent call last):
autotest-0.0.2-r8002:   File "/build/samus/tmp/portage/chromeos-base/autotest-0.0.2-r8002/work/autotest-0.0.2/frontend/afe/models_test.py", line 274, in test_job
autotest-0.0.2-r8002:     global_config.global_config.override_config_value(
autotest-0.0.2-r8002: NameError: global name 'global_config' is not defined
autotest-0.0.2-r8002: 
autotest-0.0.2-r8002: ----------------------------------------------------------------------
autotest-0.0.2-r8002: Ran 25 tests in 14.092s
autotest-0.0.2-r8002: 
autotest-0.0.2-r8002: FAILED (errors=2)
autotest-0.0.2-r8002: Traceback (most recent call last):
autotest-0.0.2-r8002:   File "./utils/unittest_suite.py", line 287, in <module>
autotest-0.0.2-r8002:     main()
autotest-0.0.2-r8002:   File "./utils/unittest_suite.py", line 274, in main
autotest-0.0.2-r8002:     errors = find_and_run_tests(absolute_start, options)
autotest-0.0.2-r8002:   File "./utils/unittest_suite.py", line 257, in find_and_run_tests
autotest-0.0.2-r8002:     pe.run_until_completion()
autotest-0.0.2-r8002:   File "/build/samus/tmp/portage/chromeos-base/autotest-0.0.2-r8002/work/autotest-0.0.2/utils/parallel.py", line 67, in run_until_completion
autotest-0.0.2-r8002:     self._run(self.ready_to_run.pop())
autotest-0.0.2-r8002:   File "/build/samus/tmp/portage/chromeos-base/autotest-0.0.2-r8002/work/autotest-0.0.2/utils/parallel.py", line 53, in _run
autotest-0.0.2-r8002:     function()
autotest-0.0.2-r8002:   File "./utils/unittest_suite.py", line 247, in <lambda>
autotest-0.0.2-r8002:     run_module = lambda module=module_names: run_test(module, options)
autotest-0.0.2-r8002:   File "./utils/unittest_suite.py", line 152, in run_test
autotest-0.0.2-r8002:     raise TestFailure(msg)
autotest-0.0.2-r8002: __main__.TestFailure: autotest_lib.frontend.afe.models_test had 0 failures and 2 errors.


This started happening yesterday afternoon, I am fairly sure https://chromium-review.googlesource.com/#/c/481960/ is what broke this.

Can we revert? Our Chrome and Android M are falling behind on the branch.

This looks like it was merged without a merge request?
 
Status: Started (was: Untriaged)
Sorry I will try to fix - if not I will revert in a 30 mins.
So I was unaware that parameterized jobs were actually used on R58

If we revert this it just break moblab - we need to CP the final fix as well - let me see if that CP cleanly.
I create a revert of the revert here:

https://chromium-review.googlesource.com/#/c/487722/

I just need a +2

I will assign the moblab bug to Richard since I obviously do not understand the implications of his change, but we need 58 moblab fixed soon.
Labels: M-58
Status: Fixed (was: Started)
The revert was reverted

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment