New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715394 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Dec 2017
Cc:
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MD History: CSS consistency and simplicity fixes

Project Member Reported by tsergeant@chromium.org, Apr 26 2017 
There are numerous things we can do to make styling across these pages simpler, and more consistent.

1. Specify important styles at the top level <history-app>
  - Particularly `color` and `line-height`

2. Pull the cr-shared-styles in everywhere.
  - Need to check that this doesn't impact performance

3. Improve paper-icon-button-light and iron-icon styling
  - Set --iron-icon-height/width globally and remove anywhere which specifies 20px manually.
  - Use the button[is="paper-icon-button-light"] rules from cr-shared-styles to style icon buttons consistently. Remove anywhere which specifies 36px manually.
Project Member

Comment 1 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1df8e5abe3d4a6b90c62f113f35ff41974fe64b6

commit 1df8e5abe3d4a6b90c62f113f35ff41974fe64b6
Author: tsergeant <tsergeant@chromium.org>
Date: Mon May 01 06:32:11 2017

MD Bookmarks: Simplify and improve consistency of CSS

- Apply color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance
- Make item highlight colors consistent

BUG= 715394 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846673003
Cr-Commit-Position: refs/heads/master@{#468296}

[modify] https://crrev.com/1df8e5abe3d4a6b90c62f113f35ff41974fe64b6/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/1df8e5abe3d4a6b90c62f113f35ff41974fe64b6/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/1df8e5abe3d4a6b90c62f113f35ff41974fe64b6/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/1df8e5abe3d4a6b90c62f113f35ff41974fe64b6/chrome/browser/resources/md_bookmarks/shared_style.html
[modify] https://crrev.com/1df8e5abe3d4a6b90c62f113f35ff41974fe64b6/chrome/browser/resources/md_bookmarks/shared_vars.html

Comment 2 by tsergeant@chromium.org, Jul 28 2017

Cc: tsergeant@chromium.org
Components: -UI>Browser>Bookmarks
Labels: -Pri-2 Pri-3
Owner: calamity@chromium.org
Summary: MD History: CSS consistency and simplicity fixes (was: MD History & Bookmarks: CSS consistency and simplicity fixes)
This is fixed for Bookmarks. I've got a WIP CL to do some similar things for MD History here: https://chromium-review.googlesource.com/590511.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19a05f534b589a183b348964dad0fd02e907939f

commit 19a05f534b589a183b348964dad0fd02e907939f
Author: Christopher Lam <calamity@chromium.org>
Date: Thu Nov 30 06:00:06 2017

[MD History] Simplify and improve consistency of CSS.

This CL is based on
https://chromium-review.googlesource.com/c/chromium/src/+/590511.

- Apply line-height to the whole page.
- Shares paper-icon-button-light sizing styles.
- Removes an unnecessary class from synced_device_card.html.
- Changes the padding on synced card buttons to more closely
  match mocks.

Bug:  715394 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0152f95a4d96b384acac35ebfe4cd2959e8f8d58
Reviewed-on: https://chromium-review.googlesource.com/795402
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520454}
[modify] https://crrev.com/19a05f534b589a183b348964dad0fd02e907939f/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/19a05f534b589a183b348964dad0fd02e907939f/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/19a05f534b589a183b348964dad0fd02e907939f/chrome/browser/resources/md_history/shared_style.html
[modify] https://crrev.com/19a05f534b589a183b348964dad0fd02e907939f/chrome/browser/resources/md_history/shared_vars.html
[modify] https://crrev.com/19a05f534b589a183b348964dad0fd02e907939f/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/19a05f534b589a183b348964dad0fd02e907939f/chrome/browser/resources/md_history/synced_device_card.html

Comment 4 by calamity@chromium.org, Dec 1 2017

Status: Fixed (was: Assigned)
I think that's all there is to do here? Gonna mark this fixed.
►

Sign in to add a comment