New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715393 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Create metrics for LSD / geolocation API usage vs battery level

Project Member Reported by benwells@chromium.org, Apr 26 2017

Issue description

Suggestion:

We'd create some histograms which record the battery level bucket (e.g. in 10% chunks) of the following actions:
- Acceptance of a geolocation permission prompt
- Denial of a geolocation permissions prompt
- Ignoring of a geolocation permissions prompt
- Dismissal of a geolocation permissions prompt
- Acceptance of the LSD
- Rejection of the LSD.

How does that sound? I think it would give us information that could inform how much battery level affects geolocation use, and to potentially have battery level as an input to the LSD backoff.

msramek: Would this be OK from a privacy perspective?
 
No issues from my side.
SGTM. I was originally imagining just the LSD histograms, but broadening to other GEO-relevant moments is a neat expansion. 
sgtm as well, thanks!
Labels: -M-60 M-61
Hey, we're analyzing LSD impact and this would be extremely useful, did this make it to M61?
Cc: timloh@chromium.org
Labels: -M-61
Owner: ----
Status: Available (was: Assigned)
No, sorry. I think we need to find a new owner for this.

Raymes / Tim - any takers?
Cc: benwells@chromium.org
Owner: timloh@chromium.org
Status: Assigned (was: Available)
Labels: -Pri-2 Pri-1
Tim, thanks for taking this on. I'm going to bump the priority because I think this will be pretty important to evolving our LSD logic. Let us know what milestone you're targeting

Comment 9 by timloh@chromium.org, Aug 24 2017

Labels: M-63
Tagging this as 63 but let me know if you want it more urgently (I haven't started looking at it yet).
Components: Blink>Geolocation
Components: -Blink>Location
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c29eb6132b1c8c0aa6fa4fbaff76f794eb5ce1d

commit 8c29eb6132b1c8c0aa6fa4fbaff76f794eb5ce1d
Author: Timothy Loh <timloh@chromium.org>
Date: Thu Oct 12 07:10:22 2017

Log metrics for battery level for LSD and geolocation permission usage

This patch adds histograms which record battery level (decile) for:
- Accept/Deny/Dismiss geolocation permission prompts on Android
- Accept/Deny the LSD on Android

Bug:  715393 
Change-Id: I5df15fee43fef2158ac9c68b9e05c50bfac0709d
Reviewed-on: https://chromium-review.googlesource.com/700277
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508272}
[add] https://crrev.com/8c29eb6132b1c8c0aa6fa4fbaff76f794eb5ce1d/chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionUmaUtil.java
[modify] https://crrev.com/8c29eb6132b1c8c0aa6fa4fbaff76f794eb5ce1d/chrome/android/java_sources.gni
[modify] https://crrev.com/8c29eb6132b1c8c0aa6fa4fbaff76f794eb5ce1d/chrome/browser/BUILD.gn
[modify] https://crrev.com/8c29eb6132b1c8c0aa6fa4fbaff76f794eb5ce1d/chrome/browser/geolocation/geolocation_permission_context_android.cc
[modify] https://crrev.com/8c29eb6132b1c8c0aa6fa4fbaff76f794eb5ce1d/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/8c29eb6132b1c8c0aa6fa4fbaff76f794eb5ce1d/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/8c29eb6132b1c8c0aa6fa4fbaff76f794eb5ce1d/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment