New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715392 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

webkit_tests failing on chromium.webkit/WebKit Linux Trusty (dbg)

Project Member Reported by alancutter@chromium.org, Apr 26 2017

Issue description

webkit_tests failing on chromium.webkit/WebKit Linux Trusty (dbg)

Builders failed on: 
- WebKit Linux Trusty (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29


Tests are failing a Skia check:

STDERR: [1:1:0425/084910.082184:2162909030:INFO:SkSurface.cpp(128)] ../../third_party/skia/src/image/SkSurface.cpp:128: fatal error: "assert(fWidth > 0)"

virtual/gpu/fast/canvas/OffscreenCanvas-empty-image-source.html
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fgpu%2Ffast%2Fcanvas%2FOffscreenCanvas-empty-image-source.html&testType=webkit_tests

virtual/gpu/fast/canvas/OffscreenCanvas-zero-size-readback.html
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fgpu%2Ffast%2Fcanvas%2FOffscreenCanvas-zero-size-readback.html&testType=webkit_tests

First failing build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20(dbg)/builds/1458

Suspected CL is a Skia roll:
https://chromium.googlesource.com/chromium/src/+/a0717ac57c2ce54ecf2ee0ed86a428a5d1566a77
 
Cc: hcm@chromium.org
Labels: -OS-Windows
Owner: xlai@chromium.org
Status: Assigned (was: Available)
Assigning to test owner to investigate.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2330a79389bf0976eea62788b434a366b0e72c5b

commit 2330a79389bf0976eea62788b434a366b0e72c5b
Author: alancutter <alancutter@chromium.org>
Date: Wed Apr 26 03:59:23 2017

Revert "Roll src/third_party/skia/ c1889823d..600effbdc (2 commits)"

This reverts commit a0717ac57c2ce54ecf2ee0ed86a428a5d1566a77.

Reason for revert: Hits Skia assertion failures for two tests:
virtual/gpu/fast/canvas/OffscreenCanvas-empty-image-source.html
virtual/gpu/fast/canvas/OffscreenCanvas-zero-size-readback.html

See bug for more details.

Original change's description:
> Roll src/third_party/skia/ c1889823d..600effbdc (2 commits)
>
> https://skia.googlesource.com/skia.git/+log/c1889823de68..600effbdc7d8
>
> $ git log c1889823d..600effbdc --date=short --no-merges --format='%ad %ae %s'
> 2017-04-24 scroggo Improve the Codec_end test and add fixes
> 2017-04-24 robertphillips Rm makeRenderTargetContext in favor of deferred version (take 3)
>
> Created with:
>   roll-dep src/third_party/skia
>
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, see:
> http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
>
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> TBR=benjaminwagner@chromium.org
>
> Change-Id: Icb5c66a3b1c30f99d72fce298a0f8c51394cae8b
> Reviewed-on: https://chromium-review.googlesource.com/486271
> Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#466989}

TBR=skia-deps-roller@chromium.org,benjaminwagner@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

BUG= 715392 

Review-Url: https://codereview.chromium.org/2846453002
Cr-Commit-Position: refs/heads/master@{#467227}

[modify] https://crrev.com/2330a79389bf0976eea62788b434a366b0e72c5b/DEPS

Comment 3 by hcm@chromium.org, Apr 26 2017

Cc: robertphillips@chromium.org
+Robert
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/78de212909a72a3ad74d652b39c941236f7047ad

commit 78de212909a72a3ad74d652b39c941236f7047ad
Author: Robert Phillips <robertphillips@google.com>
Date: Wed Apr 26 12:19:31 2017

Prevent creation of zero-sized proxies

This wasn't seen locally b.c. it is an assert and I only ran release locally and the CQ also only runs release.

I have added linux_trusty_blink_dbg as a try job.

TBR=bsalomon@google.com
Bug:  715392 
Change-Id: I010626cb97e886d2fbfd767f948bc640f0534338
Reviewed-on: https://skia-review.googlesource.com/14361
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/78de212909a72a3ad74d652b39c941236f7047ad/src/gpu/GrSurfaceProxy.cpp
[modify] https://crrev.com/78de212909a72a3ad74d652b39c941236f7047ad/tests/ProxyTest.cpp
[modify] https://crrev.com/78de212909a72a3ad74d652b39c941236f7047ad/src/gpu/GrResourceProvider.cpp

Comment 5 by xlai@chromium.org, Apr 26 2017

Cc: -robertphillips@chromium.org xlai@chromium.org
Owner: robertphillips@chromium.org
Since Robert is fixing the Skia code to prevent creation of zero-sized canvas, the tests should be passed now after the next Skia roll. Passing this issue to him to monitor the progress.

Comment 6 by junov@chromium.org, Apr 26 2017

Components: -Internals>GPU>Canvas2D Blink>Canvas

Comment 7 by sky@chromium.org, Apr 28 2017

Labels: -Sheriff-Chromium
Removing Sheriff-Chromium as it's no longer an issue on the waterfall. I would be tempted to mark the bug as fixed as well, but I leave that to you.
Status: Fixed (was: Assigned)

Sign in to add a comment