New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715382 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 712963



Sign in to add a comment

Modify code formerly in web/ so that it doesn't use accessibility classes in modules/ directly.

Project Member Reported by sashab@chromium.org, Apr 26 2017

Issue description

As part of merging Source/web/ into modules/ & core/, we would like to remove web/'s dependencies on modules/ so that as many classes can go into core/ as possible.

Many classes in web/ rely on parts of modules/accessibility/ (e.g. AXObject.h and AXObjectCacheImpl.h, such as WebNode, WebPagePopupImpl, WebDocument, WebViewImpl, etc). If we can remove this dependency, we can move these classes into core/.

Some ideas for how to remove this dependency, in generally descending order from best to worst:
1. Move as much of accessibility as possible out of modules/ (e.g. to core/, or even platform/modules). AXObjectCacheImpl.cpp uses ChromeClient to call back into core/ already, so we can remove this abstraction layer too
2. Split accessibility into parts dependent on modules/ and parts not dependent, and move the not-dependent parts to another location as in 1)
3. Rename AXObject to AXObjectImpl and introduce an abstraction of AXObject in core/ (like AXObjectCache already has)
4. ??? Something else :)

Ideas welcome. I'll start a thread to discuss this on platform-architecture-dev@chromium.org and hopefully flesh out a design doc with the choices and their work.

 

Comment 1 by sashab@chromium.org, Apr 26 2017

Cc: slangley@chromium.org

Comment 2 by sashab@chromium.org, Apr 26 2017

Cc: aleventhal@chromium.org dtseng@chromium.org nek...@chromium.org
I think we started on:

3. Rename AXObject to AXObjectImpl and introduce an abstraction of AXObject in core/ (like AXObjectCache already has)

Let me know if you'd like to discuss this.

Project Member

Comment 4 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/234813ae8d52f622a1664e11365642751e8f26ba

commit 234813ae8d52f622a1664e11365642751e8f26ba
Author: sashab <sashab@chromium.org>
Date: Mon May 15 04:17:05 2017

Rename AXObject to AXObjectImpl in modules/ and web/

Rename AXObject to AXObjectImpl in modules/ and web/, and introduce an
empty abstract parent class in core/. This is pre-work to remove usages
of AXObjectImpl from web/, which will use AXObject instead.

This patch does not rename the usages in core/ since these should use
the new abstract object.

BUG= 715382 

Review-Url: https://codereview.chromium.org/2858493002
Cr-Commit-Position: refs/heads/master@{#471663}

[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/docs/accessibility/overview.md
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash.html
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/LayoutTests/accessibility/display-none-change.html
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles-expected.txt
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/dom/AXObjectCache.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/HTMLInputElement.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/ColorChooser.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/ColorInputType.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/DateTimeChooser.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/InputTypeView.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/InputTypeView.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/core/page/PagePopup.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXListBox.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXMockObject.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXMockObject.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[rename] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[rename] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXSlider.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXTable.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXTableCell.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXTableColumn.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/AXTableRow.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/BUILD.gn
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/accessibility/testing/InternalsAccessibility.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/ColorChooserPopupUIController.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/ColorChooserUIController.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/ColorChooserUIController.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/DateTimeChooserImpl.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/ExternalDateTimeChooser.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/WebDocument.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/WebPagePopupImpl.h
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/234813ae8d52f622a1664e11365642751e8f26ba/third_party/WebKit/public/web/WebAXObject.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b88633c21b9db5ffcb316d744452625ccb5061e9

commit b88633c21b9db5ffcb316d744452625ccb5061e9
Author: sashab <sashab@chromium.org>
Date: Tue May 16 01:38:56 2017

Revert of Rename AXObject to AXObjectImpl in modules/ and web/ (patchset #9 id:160001 of https://codereview.chromium.org/2858493002/ )

Reason for revert:
Landed wrong patchset.

Original issue's description:
> Rename AXObject to AXObjectImpl in modules/ and web/
>
> Rename AXObject to AXObjectImpl in modules/ and web/, and introduce an
> empty abstract parent class in core/. This is pre-work to remove usages
> of AXObjectImpl from web/, which will use AXObject instead.
>
> This patch does not rename the usages in core/ since these should use
> the new abstract object.
>
> BUG= 715382 
>
> Review-Url: https://codereview.chromium.org/2858493002
> Cr-Commit-Position: refs/heads/master@{#471663}
> Committed: https://chromium.googlesource.com/chromium/src/+/234813ae8d52f622a1664e11365642751e8f26ba

TBR=aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 715382 

Review-Url: https://codereview.chromium.org/2883203002
Cr-Commit-Position: refs/heads/master@{#471975}

[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/docs/accessibility/overview.md
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash.html
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/LayoutTests/accessibility/display-none-change.html
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles-expected.txt
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/dom/AXObjectCache.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/HTMLInputElement.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/ColorChooser.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/ColorInputType.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/DateTimeChooser.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/InputTypeView.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/InputTypeView.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/core/page/PagePopup.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXListBox.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXMockObject.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXMockObject.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[rename] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[rename] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXSlider.h
[modify] https://crrev.com/b88633c21b9db5ffcb316d744452625ccb5061e9/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f393a79bfdbef6b60a59d362456a77f69e9da920

commit f393a79bfdbef6b60a59d362456a77f69e9da920
Author: rockot <rockot@chromium.org>
Date: Tue May 16 02:08:24 2017

Reland of name AXObject to AXObjectImpl in modules/ and web/ (patchset #1 id:1 of https://codereview.chromium.org/2883203002/ )

Reason for revert:
Lots of breakage across all CQ builders e.g. https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/454351

Looks like the revert is missing a BUILD.gn update at least

Original issue's description:
> Revert of Rename AXObject to AXObjectImpl in modules/ and web/ (patchset #9 id:160001 of https://codereview.chromium.org/2858493002/ )
>
> Reason for revert:
> Landed wrong patchset.
>
> Original issue's description:
> > Rename AXObject to AXObjectImpl in modules/ and web/
> >
> > Rename AXObject to AXObjectImpl in modules/ and web/, and introduce an
> > empty abstract parent class in core/. This is pre-work to remove usages
> > of AXObjectImpl from web/, which will use AXObject instead.
> >
> > This patch does not rename the usages in core/ since these should use
> > the new abstract object.
> >
> > BUG= 715382 
> >
> > Review-Url: https://codereview.chromium.org/2858493002
> > Cr-Commit-Position: refs/heads/master@{#471663}
> > Committed: https://chromium.googlesource.com/chromium/src/+/234813ae8d52f622a1664e11365642751e8f26ba
>
> TBR=aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 715382 
>
> Review-Url: https://codereview.chromium.org/2883203002
> Cr-Commit-Position: refs/heads/master@{#471975}
> Committed: https://chromium.googlesource.com/chromium/src/+/b88633c21b9db5ffcb316d744452625ccb5061e9

TBR=aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org,sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 715382 

Review-Url: https://codereview.chromium.org/2883813005
Cr-Commit-Position: refs/heads/master@{#471980}

[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/docs/accessibility/overview.md
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash.html
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/LayoutTests/accessibility/display-none-change.html
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles-expected.txt
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/dom/AXObjectCache.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/HTMLInputElement.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/ColorChooser.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/ColorInputType.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/DateTimeChooser.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/InputTypeView.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/InputTypeView.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/core/page/PagePopup.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXListBox.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXMockObject.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXMockObject.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[rename] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[rename] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXSlider.h
[modify] https://crrev.com/f393a79bfdbef6b60a59d362456a77f69e9da920/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

Project Member

Comment 8 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b9536581f36776f9a9cc13462d4d7f369686734

commit 2b9536581f36776f9a9cc13462d4d7f369686734
Author: peria <peria@chromium.org>
Date: Tue May 16 02:20:36 2017

Revert of [Sheriff] Followup a revert ; update BUILD.gn (patchset #1 id:1 of https://codereview.chromium.org/2881093004/ )

Reason for revert:
The broken tree was fixed by another change.
This CL is not needed.

Original issue's description:
> This is a follow-up CL of https://codereview.chromium.org/2883203002
>
> BUILD.gn was not updated.
>
>
> TBR=sashab@chromium.org,aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 715382 
>
> Review-Url: https://codereview.chromium.org/2881093004
> Cr-Commit-Position: refs/heads/master@{#471982}
> Committed: https://chromium.googlesource.com/chromium/src/+/003d66dbf407abf317a5bcfc7ebcbf5c2daa1c59

TBR=sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 715382 

Review-Url: https://codereview.chromium.org/2883963004
Cr-Commit-Position: refs/heads/master@{#471984}

[modify] https://crrev.com/2b9536581f36776f9a9cc13462d4d7f369686734/third_party/WebKit/Source/modules/accessibility/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b498325ab6ea7c253b73d65eaf15de7c9bf073e9

commit b498325ab6ea7c253b73d65eaf15de7c9bf073e9
Author: sashab <sashab@chromium.org>
Date: Wed May 17 01:18:46 2017

Revert of Rename AXObject to AXObjectImpl in modules/ and web/ (patchset #9 id:160001 of https://codereview.chromium.org/2858493002/ )

Reason for revert:
Landed wrong patchset.

Original issue's description:
> Rename AXObject to AXObjectImpl in modules/ and web/
>
> Rename AXObject to AXObjectImpl in modules/ and web/, and introduce an
> empty abstract parent class in core/. This is pre-work to remove usages
> of AXObjectImpl from web/, which will use AXObject instead.
>
> This patch does not rename the usages in core/ since these should use
> the new abstract object.
>
> BUG= 715382 
>
> Review-Url: https://codereview.chromium.org/2858493002
> Cr-Commit-Position: refs/heads/master@{#471663}
> Committed: https://chromium.googlesource.com/chromium/src/+/234813ae8d52f622a1664e11365642751e8f26ba

TBR=aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 715382 

Review-Url: https://codereview.chromium.org/2887613002
Cr-Commit-Position: refs/heads/master@{#472281}

[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/docs/accessibility/overview.md
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash.html
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/LayoutTests/accessibility/display-none-change.html
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles-expected.txt
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/dom/AXObjectCache.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/HTMLInputElement.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/ColorChooser.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/ColorInputType.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/DateTimeChooser.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/InputTypeView.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/InputTypeView.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/core/page/PagePopup.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXListBox.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXMockObject.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXMockObject.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[rename] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[rename] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXSlider.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXTable.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXTableCell.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXTableColumn.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/AXTableRow.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/BUILD.gn
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/accessibility/testing/InternalsAccessibility.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/ColorChooserPopupUIController.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/ColorChooserUIController.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/ColorChooserUIController.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/DateTimeChooserImpl.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/ExternalDateTimeChooser.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/WebDocument.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/WebPagePopupImpl.h
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/b498325ab6ea7c253b73d65eaf15de7c9bf073e9/third_party/WebKit/public/web/WebAXObject.h

Project Member

Comment 10 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cd996b5bea03c783b7d10062a669da39e2191da

commit 0cd996b5bea03c783b7d10062a669da39e2191da
Author: sashab <sashab@chromium.org>
Date: Wed May 17 07:31:46 2017

Rename AXObject to AXObjectImpl in modules/ and web/

Rename AXObject to AXObjectImpl in modules/ and web/, and introduce an
empty abstract parent class in core/. This is pre-work to remove usages
of AXObjectImpl from web/, which will use AXObject instead.

This patch does not rename the usages in core/ since these should use
the new abstract object.

BUG= 715382 

Review-Url: https://codereview.chromium.org/2858493002
Cr-Original-Commit-Position: refs/heads/master@{#471663}
Committed: https://chromium.googlesource.com/chromium/src/+/234813ae8d52f622a1664e11365642751e8f26ba
Review-Url: https://codereview.chromium.org/2858493002
Cr-Commit-Position: refs/heads/master@{#472370}

[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/docs/accessibility/overview.md
[add] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/core/dom/AXObject.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXListBox.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXMockObject.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXMockObject.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[rename] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[rename] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXSlider.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXTable.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXTableCell.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXTableColumn.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/AXTableRow.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/BUILD.gn
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/accessibility/testing/InternalsAccessibility.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/web/WebDocument.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/0cd996b5bea03c783b7d10062a669da39e2191da/third_party/WebKit/public/web/WebAXObject.h

Project Member

Comment 11 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2bc18b08c8f89e49dccb2c9708c64ec318aadf7

commit c2bc18b08c8f89e49dccb2c9708c64ec318aadf7
Author: sashab <sashab@chromium.org>
Date: Mon May 22 05:51:48 2017

Introduce AXObjectCacheBase in core/ and remove WebNode dependency

Introduce AXObjectCacheBase in core/ and add a pure virtual Get()
method, which removes the WebNode dependency on AXObjectCacheImpl since
it can use AXObjectCacheBase instead.

In follow-up patches, more methods will be added to AXObjectCacheBase
to remove the dependency of web/ files on modules/accessibility/.
Finally, AXObjectCacheBase will be refactored into AXObjectCache and
removed.

BUG= 715382 

Review-Url: https://codereview.chromium.org/2880993002
Cr-Commit-Position: refs/heads/master@{#473509}

[add] https://crrev.com/c2bc18b08c8f89e49dccb2c9708c64ec318aadf7/third_party/WebKit/Source/core/dom/AXObjectCacheBase.cpp
[add] https://crrev.com/c2bc18b08c8f89e49dccb2c9708c64ec318aadf7/third_party/WebKit/Source/core/dom/AXObjectCacheBase.h
[modify] https://crrev.com/c2bc18b08c8f89e49dccb2c9708c64ec318aadf7/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/c2bc18b08c8f89e49dccb2c9708c64ec318aadf7/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/c2bc18b08c8f89e49dccb2c9708c64ec318aadf7/third_party/WebKit/Source/web/WebNode.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c8a94628140cb5c3a626519a99eced7e04c74a4

commit 7c8a94628140cb5c3a626519a99eced7e04c74a4
Author: Nicholas Verne <nverne@chromium.org>
Date: Tue Jun 06 04:01:39 2017

Allows WebAXObject creation from a const WebNode.

To avoid const_cast-ing the FromWebNode() argument, AXObjectCacheBase's
getter changed from Get(Node*) to Get(const Node*), and the underlying 
WebHashMap in AXObjectCacheImpl now uses Member<const Node> as its key
type. 

Bug:  715382 
Change-Id: I1fbc9cd5de32dfd6c6b38286388e22e28e66f0cf
Reviewed-on: https://chromium-review.googlesource.com/523925
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477189}
[modify] https://crrev.com/7c8a94628140cb5c3a626519a99eced7e04c74a4/third_party/WebKit/Source/core/dom/AXObjectCacheBase.h
[modify] https://crrev.com/7c8a94628140cb5c3a626519a99eced7e04c74a4/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/7c8a94628140cb5c3a626519a99eced7e04c74a4/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/7c8a94628140cb5c3a626519a99eced7e04c74a4/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/7c8a94628140cb5c3a626519a99eced7e04c74a4/third_party/WebKit/public/web/WebAXObject.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31bc2815c45ac2e60097dd5e205f287233516c15

commit 31bc2815c45ac2e60097dd5e205f287233516c15
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Jun 07 00:10:14 2017

Remove unused AXObject includes.

Bug:  715382 
Change-Id: Ia9ec7c230666523b747db922665133260345c036
Reviewed-on: https://chromium-review.googlesource.com/525733
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477474}
[modify] https://crrev.com/31bc2815c45ac2e60097dd5e205f287233516c15/third_party/WebKit/Source/web/WebViewImpl.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62ef7ec882c9458a5747a8c819d20285179e0644

commit 62ef7ec882c9458a5747a8c819d20285179e0644
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Jun 07 07:58:22 2017

Pre-work for TextFinder to move out of web/

AXObjectImpl's complete type is no longer needed for
TextFinder to post accessiblity events. Next, we can
change usage of WebAXObject to AXObject and eliminate 
explicit use of AXObjectImpl. After this it should be
possible to move TextFinder to core/.

Bug:  715382 
Change-Id: Ib6dcede044552ab3ac9ef628345ebdec2c7a5ce0
Reviewed-on: https://chromium-review.googlesource.com/526554
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477577}
[modify] https://crrev.com/62ef7ec882c9458a5747a8c819d20285179e0644/third_party/WebKit/Source/core/dom/AXObjectCache.h
[modify] https://crrev.com/62ef7ec882c9458a5747a8c819d20285179e0644/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/62ef7ec882c9458a5747a8c819d20285179e0644/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/62ef7ec882c9458a5747a8c819d20285179e0644/third_party/WebKit/Source/web/TextFinder.cpp

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f82f0c7d49ebf5543645702555af177c7cde6bed

commit f82f0c7d49ebf5543645702555af177c7cde6bed
Author: Nicholas Verne <nverne@chromium.org>
Date: Tue Jun 13 03:06:49 2017

Remove explicit use of WebAXObject form TextFinder.cpp

Bug:  715382 
Change-Id: Icef1f5f3a675eed39885a1f25a82a9b7ef4a2439
Reviewed-on: https://chromium-review.googlesource.com/531914
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478876}
[modify] https://crrev.com/f82f0c7d49ebf5543645702555af177c7cde6bed/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f82f0c7d49ebf5543645702555af177c7cde6bed/content/renderer/render_frame_impl.h
[modify] https://crrev.com/f82f0c7d49ebf5543645702555af177c7cde6bed/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/f82f0c7d49ebf5543645702555af177c7cde6bed/third_party/WebKit/public/web/WebFrameClient.h

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b70e6e172fe3cbfe860678ca27cc5ef5c0c0003e

commit b70e6e172fe3cbfe860678ca27cc5ef5c0c0003e
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Jun 14 03:41:04 2017

Removes references to modules/accessibility from WebPagePopupImpl.

Get* methods in AXObjectCacheBase are now declared to return AXObject*.
The overrides in AXObjectCacheImpl return AXObjectImpl, which is 
covariant and therefore allowed. This means that WebAXObject always needs
to use AXObjectCacheImpl explicitly. 

Bug:  715382 
Change-Id: Iec82f48dfd721cda0d7ae0bc021af3350da1733a
Reviewed-on: https://chromium-review.googlesource.com/534176
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479275}
[modify] https://crrev.com/b70e6e172fe3cbfe860678ca27cc5ef5c0c0003e/third_party/WebKit/Source/core/dom/AXObjectCacheBase.h
[modify] https://crrev.com/b70e6e172fe3cbfe860678ca27cc5ef5c0c0003e/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/b70e6e172fe3cbfe860678ca27cc5ef5c0c0003e/third_party/WebKit/Source/modules/exported/WebAXObject.cpp
[modify] https://crrev.com/b70e6e172fe3cbfe860678ca27cc5ef5c0c0003e/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

This bug has a lot of state. It has also changed direction recently as I've been working with dmazzoni on it. 

The title should now be restated as 

"Modify code in web/ so that it doesn't use accessibility classes in modules/ directly."

By "code in web/" we're referring mainly to the WebXXX files that deal with WebNode and related classes. 

The current strategy is now: put methods on AXObjectCache that can be used by the web/ classes. They should no longer use AXObject directly. 


Owner: nverne@chromium.org
Summary: Modify in formerly in web/ so that it doesn't use accessibility classes in modules/ directly. (was: Move accessibility classes needed by web/ out of modules/)
Summary: Modify code formerly in web/ so that it doesn't use accessibility classes in modules/ directly. (was: Modify in formerly in web/ so that it doesn't use accessibility classes in modules/ directly.)
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b5b587f547319a4dc72d06fc25b0494826fd9cd

commit 1b5b587f547319a4dc72d06fc25b0494826fd9cd
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Jun 21 04:00:31 2017

Remove AXObjectImpl and replace with AXObject

AXObject's enums are now in AXEnums.h

Bug:  715382 
Change-Id: Ic9d3f47ecc59acf794fe7650cb2e17f5261ae998
Reviewed-on: https://chromium-review.googlesource.com/542096
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481107}
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/core/dom/AXObjectCacheBase.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/core/editing/TextFinder.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp
[add] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXEnums.cpp
[add] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXEnums.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXListBox.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXMockObject.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXMockObject.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[delete] https://crrev.com/97f626b5056ea67661a8dfe76c7acfeef3572b1d/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[delete] https://crrev.com/97f626b5056ea67661a8dfe76c7acfeef3572b1d/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXSlider.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXTable.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXTableCell.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXTableColumn.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/AXTableRow.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/BUILD.gn
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/accessibility/testing/InternalsAccessibility.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/modules/exported/WebAXObject.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp
[modify] https://crrev.com/1b5b587f547319a4dc72d06fc25b0494826fd9cd/third_party/WebKit/public/web/WebAXObject.h

Status: Fixed (was: Assigned)

Sign in to add a comment