[Findit] Support try jobs on iOS |
|||
Issue descriptionBuilding for iOS on the main waterfall uses a special recipe, namely "ios/unified_builder_tester" as opposed to "chromium" for desktop. Because Findit's compile/test try job recipes are based on chromium, they are not compatible with iOS, so a new recipe would be needed to support running iOS try jobs
,
Apr 26 2017
robertocn@ is more familiar with this area, but looking at RunSteps in the recipes iOS's unified_builder_tester.py looks something like
def RunSteps(api):
api.ios.checkout()
api.ios.read_build_config()
api.ios.build()
api.ios.upload()
api.ios.test_swarming()
whereas for chromium.py it looks more like
def RunSteps(api):
# build/tests/masters_recipes_tests.py needs to manipulate the BUILDERS
# dict, so we provide an API to dump it here.
if api.properties.get('dump_builders'): # pragma: no cover
api.file.write(
'Dump BUILDERS dict', api.properties['dump_builders'],
api.json.dumps(api.chromium_tests.builders, default=ignore_undumpable))
return
api.chromium_tests.main_waterfall_steps()
Roberto, can you please help provide a bit more insight as to what it would take to support iOS?
,
Apr 26 2017
We would need to go into the ios module and figure out how it differs from the chromium recipe, and modify the findit compile recipe to call the ios equivalents of the chromium steps (if at all possible)
,
Apr 27 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 27 2018
Per discussion a while ago with Dirk, iOS recipes will be merged into the common chromium_trybot recipe, and we don't have to do anything special after that. |
|||
►
Sign in to add a comment |
|||
Comment 1 by st...@chromium.org
, Apr 26 2017Status: Available (was: Untriaged)