New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715372 link

Starred by 1 user
Status: Fixed
Owner:
█ iannucci@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ phajdan.jr@chromium.org
d...@chromium.org
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug



Sign in to add a comment

Missing GenTests() causes an obscure crash in recipes.py

Project Member Reported by sergeybe...@chromium.org, Apr 26 2017 
I had a typo in the GenTests() function name (GetTests), and 'recipes.py test train' crashed with a generic message:

Exception: While generating results for 'presubmit': TypeError: 'NoneType' object is not callable
Uncaught exception (Exception): While generating results for 'presubmit': TypeError: 'NoneType' object is not callable

It would've saved me quite a bit of time if recipes.py detected the absence of GenTests and printed a helpful message.

Comment 1 by martiniss@chromium.org, Apr 26 2017

Cc: d...@chromium.org phajdan.jr@chromium.org
https://cs.chromium.org/chromium/infra/recipes-py/recipe_engine/loader.py?l=41 is the relevant code. Looks like it doesn't take the absence of these as bad.

We should probably make that an error.

dnj@ touched that code most recently...

Comment 2 by phajdan.jr@chromium.org, Apr 27 2017

Labels: -Restrict-View-Google
Owner: phajdan.jr@chromium.org
Status: Started (was: Untriaged)
Uploaded https://codereview.chromium.org/2845133002/ .

Comment 3 by phajdan.jr@chromium.org, May 8 2017

Owner: iannucci@chromium.org
Status: Fixed (was: Started)
This was fixed by Robbie's https://codereview.chromium.org/2864803003 .
►

Sign in to add a comment