Hide ARC popup notification on non-primary display. |
|||||||||||||||
Issue descriptionARC popup notification is broken on multiple display. Let me hide it on non-primary display.
,
Apr 26 2017
ARC notification hosts a window of exosphere surface, which contains the pixel buffer of the content of Android notification. In the current implementation of ARC notification, a surface can't be shared by multiple hosts. Only one view can host a surface. This is the logic of "broken" on multiple displays. In near feature, we need to add some way to share a surface among multiple hosts (this issue), but it need some work. As for now, we're disabling popup on non-primary display ( Issue 715362 ).
,
Apr 26 2017
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bb91538766f932d182801724d0c0d1826e6dde6 commit 7bb91538766f932d182801724d0c0d1826e6dde6 Author: yoshiki <yoshiki@chromium.org> Date: Wed Apr 26 17:54:43 2017 Hide popup custom notifications on non-primary displays Currently custom notifications are supported to be shown only on one display at the same time. So this CL disables popup custom notification on non-primary displays. This CL affects only on Chrome OS. BUG=b/37456756 BUG= 715362 TEST=manual Review-Url: https://codereview.chromium.org/2834773002 Cr-Commit-Position: refs/heads/master@{#467377} [modify] https://crrev.com/7bb91538766f932d182801724d0c0d1826e6dde6/ash/system/web_notification/ash_popup_alignment_delegate.cc [modify] https://crrev.com/7bb91538766f932d182801724d0c0d1826e6dde6/ash/system/web_notification/ash_popup_alignment_delegate.h [modify] https://crrev.com/7bb91538766f932d182801724d0c0d1826e6dde6/ui/message_center/views/desktop_popup_alignment_delegate.cc [modify] https://crrev.com/7bb91538766f932d182801724d0c0d1826e6dde6/ui/message_center/views/desktop_popup_alignment_delegate.h [modify] https://crrev.com/7bb91538766f932d182801724d0c0d1826e6dde6/ui/message_center/views/message_popup_collection.cc [modify] https://crrev.com/7bb91538766f932d182801724d0c0d1826e6dde6/ui/message_center/views/popup_alignment_delegate.h
,
Apr 26 2017
,
Apr 26 2017
,
Apr 26 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2017
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13730d071f734642a4749d0fa531d87095e63d25 commit 13730d071f734642a4749d0fa531d87095e63d25 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Apr 27 00:35:06 2017 Hide popup custom notifications on non-primary displays Currently custom notifications are supported to be shown only on one display at the same time. So this CL disables popup custom notification on non-primary displays. This CL affects only on Chrome OS. BUG=b/37456756 BUG= 715362 TEST=manual Review-Url: https://codereview.chromium.org/2834773002 Cr-Commit-Position: refs/heads/master@{#467377} (cherry picked from commit 7bb91538766f932d182801724d0c0d1826e6dde6) Review-Url: https://codereview.chromium.org/2841323002 . Cr-Commit-Position: refs/branch-heads/3071@{#246} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ash/system/web_notification/ash_popup_alignment_delegate.cc [modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ash/system/web_notification/ash_popup_alignment_delegate.h [modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ui/message_center/views/desktop_popup_alignment_delegate.cc [modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ui/message_center/views/desktop_popup_alignment_delegate.h [modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ui/message_center/views/message_popup_collection.cc [modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ui/message_center/views/popup_alignment_delegate.h
,
Apr 27 2017
Bernie, Chrome PFQ hasn't rolled in a couple days so we haven't been able to officially test in a canary image. This (https://codereview.chromium.org/2834773002) is a fix for M and N IIUC and a pretty bad UX, can we get clearance to merge after manual testing?
,
Apr 27 2017
For this one, lets see if we can get a Chrome roll with this change (on ToT or 59) to fully validate. If we have verified it add the merge request again and we can take another look.
,
May 10 2017
did you verify on tot?
,
May 10 2017
I did
,
May 11 2017
re #11, I think bernie was waiting for verification on ToT for merge request to M58.
,
May 11 2017
Oh sorry, I thought that means we should reconsider merging to M58 since the milestone is changed. I verified on the latest canary, so it's working.
,
May 11 2017
It's not a crash and not high priority but good to have. Can I merge this to M58 if possible?
,
May 11 2017
We can merge this, but note that we have already built our RC, and we may not get another 58 stable.
,
May 15 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2017
Thank you for information. I think this is not critical for M58, since it's not crash and affects only for multiple display environment. Let me close this without merging to M58. Note that it's already merged to M59.
,
May 15 2017
,
May 19 2017
9460.42.0, 59.0.3071.57 |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by steve...@chromium.org
, Apr 26 2017