New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715362 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Hide ARC popup notification on non-primary display.

Project Member Reported by yoshiki@chromium.org, Apr 26 2017

Issue description

ARC popup notification is broken on multiple display. Let me hide it on non-primary display.
 
Could you please provide more details? What is "broken", and why is it limited to ARC notifications?

ARC notification hosts a window of exosphere surface, which contains the pixel buffer of the content of Android notification.

In the current implementation of ARC notification, a surface can't be shared by multiple hosts. Only one view can host a surface. This is the logic of "broken" on multiple displays.

In near feature, we need to add some way to share a surface among multiple hosts (this issue), but it need some work. As for now, we're disabling popup on non-primary display ( Issue 715362 ).

Comment 3 by xiy...@chromium.org, Apr 26 2017

Cc: xiy...@chromium.org yoshiki@chromium.org
 Issue 661723  has been merged into this issue.
Labels: Merge-Request-58
Labels: Merge-Request-59
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 26 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by gkihumba@google.com, Apr 26 2017

Labels: Merge-Approved-59
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 27 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13730d071f734642a4749d0fa531d87095e63d25

commit 13730d071f734642a4749d0fa531d87095e63d25
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Apr 27 00:35:06 2017

Hide popup custom notifications on non-primary displays

Currently custom notifications are supported to be shown only
on one display at the same time. So this CL disables popup custom notification on non-primary displays.

This CL affects only on Chrome OS.

BUG=b/37456756
BUG= 715362 
TEST=manual

Review-Url: https://codereview.chromium.org/2834773002
Cr-Commit-Position: refs/heads/master@{#467377}
(cherry picked from commit 7bb91538766f932d182801724d0c0d1826e6dde6)

Review-Url: https://codereview.chromium.org/2841323002 .
Cr-Commit-Position: refs/branch-heads/3071@{#246}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ash/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ash/system/web_notification/ash_popup_alignment_delegate.h
[modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ui/message_center/views/desktop_popup_alignment_delegate.cc
[modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ui/message_center/views/desktop_popup_alignment_delegate.h
[modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/13730d071f734642a4749d0fa531d87095e63d25/ui/message_center/views/popup_alignment_delegate.h

Cc: bhthompson@chromium.org
Bernie, Chrome PFQ hasn't rolled in a couple days so we haven't been able to officially test in a canary image.  This (https://codereview.chromium.org/2834773002) is a fix for M and N IIUC and a pretty bad UX, can we get clearance to merge after manual testing?
Labels: -Hotlist-Merge-Review -Merge-Review-58 -Merge-Request-59 M-59
For this one, lets see if we can get a Chrome roll with this change (on ToT or 59) to fully validate.

If we have verified it add the merge request again and we can take another look.

Comment 12 by uekawa@google.com, May 10 2017

did you verify on tot?
Status: Fixed (was: Started)
I did
re #11, I think bernie was waiting for verification on ToT for merge request to M58.

Oh sorry, I thought that means we should reconsider merging to M58 since the milestone is changed.

I verified on the latest canary, so it's working.
Labels: Merge-Request-58
Status: Started (was: Fixed)
It's not a crash and not high priority but good to have. Can I merge this to M58 if possible?


Labels: -Merge-Request-58 Merge-Approved-58
We can merge this, but note that we have already built our RC, and we may not get another 58 stable. 
Project Member

Comment 18 by sheriffbot@chromium.org, May 15 2017

Cc: bhthompson@google.com gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-58
Status: Fixed (was: Started)
Thank you for information. I think this is not critical for M58, since it's not crash and affects only for multiple display environment. Let me close this without merging to M58.

Note that it's already merged to M59.
Labels: -Merge-Approved-58
Status: Verified (was: Fixed)
9460.42.0, 59.0.3071.57

Sign in to add a comment