Consider not using unordered_map in camera_config_chromeos.h |
||||
Issue descriptionBecause is discouraged in [1] for small sizes [2] [1] https://chromium.googlesource.com/chromium/src/+/master/base/containers/README.md [2] https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/chromium-dev/rdxOHKzQmRY/fgMJCEGxCgAJ grep -rn unordered_map media/capture/ media/capture//video/linux/camera_config_chromeos.h:11:#include <unordered_map> media/capture//video/linux/camera_config_chromeos.h:88: std::unordered_map<int, VideoFacingMode> camera_id_to_facing_; media/capture//video/linux/camera_config_chromeos.h:89: std::unordered_map<int, int> camera_id_to_orientation_; media/capture//video/linux/camera_config_chromeos.h:90: std::unordered_map<std::string, int> usb_id_to_camera_id_; media/capture//video/linux/camera_config_chromeos.h:91: std::unordered_map<std::string, int> model_id_to_camera_id_;
,
May 29 2017
,
May 29 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 29 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by guidou@chromium.org
, Apr 28 2017