New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715346 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

BindingManager should be used from the launcher thread

Project Member Reported by jcivelli@chromium.org, Apr 25 2017

Issue description

BindingManager should be used from the launcher thread only to make that code more robust and maintainable.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e1ea261b6194c8e14401f0a667927d4d32ac88f

commit 2e1ea261b6194c8e14401f0a667927d4d32ac88f
Author: jcivelli <jcivelli@chromium.org>
Date: Wed Apr 26 20:19:36 2017

Making BindingManager work on the launcher thread only.

BindingManager is now only accessed on the launcher thread and does not
require synchronization.
Also renamed BindingManager.determinedVisibility to onDeterminedVisibility.

BUG= 715346 

Review-Url: https://codereview.chromium.org/2843853002
Cr-Commit-Position: refs/heads/master@{#467434}

[modify] https://crrev.com/2e1ea261b6194c8e14401f0a667927d4d32ac88f/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
[modify] https://crrev.com/2e1ea261b6194c8e14401f0a667927d4d32ac88f/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
[modify] https://crrev.com/2e1ea261b6194c8e14401f0a667927d4d32ac88f/content/public/android/java/src/org/chromium/content/browser/BindingManager.java
[modify] https://crrev.com/2e1ea261b6194c8e14401f0a667927d4d32ac88f/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
[modify] https://crrev.com/2e1ea261b6194c8e14401f0a667927d4d32ac88f/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/2e1ea261b6194c8e14401f0a667927d4d32ac88f/content/public/android/java/src/org/chromium/content/browser/LauncherThread.java
[modify] https://crrev.com/2e1ea261b6194c8e14401f0a667927d4d32ac88f/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

Status: Fixed (was: Untriaged)

Sign in to add a comment