Issue 715335 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	jamescook@chromium.org
Closed:	May 2017
Cc:	xiy...@chromium.org mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
Proj-Mustash-Mash mustash-2 VerifyIn-61

Blocking:
issue 647412

mash: Refactor ash::SystemTrayDelegate enterprise methods

Project Member Reported by jamescook@chromium.org, Apr 25 2017

Issue description

These methods needs to be eliminated or converted to mojo:

  // Returns the domain that manages the device, if it is enterprise-enrolled.
  virtual std::string GetEnterpriseDomain() const;

  // Returns the realm that manages the device, if it is enterprise enrolled
  // with Active Directory and joined the realm (Active Directory domain).
  virtual std::string GetEnterpriseRealm() const;

  // Returns notification for enterprise enrolled devices.
  virtual base::string16 GetEnterpriseMessage() const;

  // Shows information about enterprise enrolled devices.
  virtual void ShowEnterpriseInfo();

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b67ae3a76893ee92586a28fd4b11640e28e12de

commit 1b67ae3a76893ee92586a28fd4b11640e28e12de
Author: jamescook <jamescook@chromium.org>
Date: Wed Apr 26 22:56:08 2017

chromeos: Refactor ash SystemTrayDelegate enterprise methods to mojo

This is needed to support mustash.

* Migrate code from SystemTrayDelegateChromeOS to SystemTrayClient
* Migrate strings into ash_strings.grd

BUG= 715335 
TEST=added to ash_unittests and chrome browser_tests

Review-Url: https://codereview.chromium.org/2839043004
Cr-Commit-Position: refs/heads/master@{#467495}

[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/BUILD.gn
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/ash_strings.grd
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/enterprise/tray_enterprise.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/enterprise/tray_enterprise.h
[add] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/enterprise/tray_enterprise_unittest.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/tray/system_tray.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/tray/system_tray.h
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/tray/system_tray_controller.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/tray/system_tray_controller.h
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/tray/system_tray_delegate.h
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/ash/system/user/user_card_view.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/chrome/browser/ui/ash/system_tray_client_browsertest.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/1b67ae3a76893ee92586a28fd4b11640e28e12de/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc