It seems we are incorrectly assuming that the url will always be properly formed. In cases like this: /waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.mac/chromium.mac/iOS_Device/1766 Where the master is accidentally repeated, the buildername is casted to int and raises exception like this: https://pantheon.corp.google.com/logs/viewer?minLogLevel=0&resource=gae_app%2Fmodule_id%2Fwaterfall-frontend%2Fversion_id%2Fd973b46cd&logName=projects%2Ffindit-for-me%2Flogs%2Fappengine.googleapis.com%252Frequest_log&expandAll=false&project=findit-for-me×tamp=2017-04-25T23%3A10%3A41.432038000Z&advancedFilter=resource.type%3D%22gae_app%22%0Aresource.labels.module_id%3D%22waterfall-frontend%22%0Aresource.labels.zone%3D%22us3%22%0Aresource.labels.project_id%3D%22findit-for-me%22%0Aresource.labels.version_id%3D%22d973b46cd%22%0Atimestamp%3D%222017-04-25T23%3A08%3A17.136704000Z%22%0AinsertId%3D%2258ffd6e100084206ca76cf7f%22 We should be handling this, and maybe returning a 404 instead of a 500
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3e50d4a91e57838f4a0faf427e20bc7348a42314 commit 3e50d4a91e57838f4a0faf427e20bc7348a42314 Author: Shuotao Gao <stgao@chromium.org> Date: Wed Apr 26 00:44:42 2017 [Findit] Properly handle milo urls in bad format. BUG= 715324 Change-Id: Ic81f3e0aaab7c70cabec6618acabbe41eb6b7bdd Reviewed-on: https://chromium-review.googlesource.com/486970 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/3e50d4a91e57838f4a0faf427e20bc7348a42314/appengine/findit/waterfall/buildbot.py
Comment 1 by st...@chromium.org
, Apr 25 2017Status: Started (was: Untriaged)