Issue metadata
Sign in to add a comment
|
base_junit_tests failing on ClangToTAndroidASan |
||||||||||||||||||||
Issue descriptionhttps://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClangToTAndroidASan%2F5259%2F%2B%2Frecipes%2Fsteps%2Fbase_junit_tests%2F0%2Fsteps%2Fbase_junit_tests%2F0%2Fstdout usage: test_runner.py [-h] {gtest,instrumentation,junit,linker,monkey,perf,python} ... test_runner.py: error: unrecognized arguments: --tool=asan step returned non-zero exit code: 2 This used to work a while ago, but the bot's been broken for unrelated things for a fairly long time.
,
Apr 25 2017
jbudorick, I think you wrote both the buildbot json file that builds the command that runs on the bot and you wrote the change that made test_runner.py error out on unknown flags, so you probably know what the right fix is (don't pass this flag? don't error out on it?).
,
Apr 26 2017
We shouldn't be passing --tool=asan for JUnit tests at all.
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4fc2b93398945ed1953483b6df3ccf433a216bf commit a4fc2b93398945ed1953483b6df3ccf433a216bf Author: jbudorick <jbudorick@chromium.org> Date: Wed Apr 26 22:54:26 2017 [Android] Don't add --tool=asan to junit wrapper scripts. BUG= 715304 Review-Url: https://codereview.chromium.org/2843053002 Cr-Commit-Position: refs/heads/master@{#467494} [modify] https://crrev.com/a4fc2b93398945ed1953483b6df3ccf433a216bf/build/config/android/internal_rules.gni
,
Apr 27 2017
https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/builds/5264 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by thakis@chromium.org
, Apr 25 2017