New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715300 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Undo Restore all options are missing for removed thumbnail when City and Bridge in the Fog theme is applied

Project Member Reported by pucchakayala@chromium.org, Apr 25 2017

Issue description

Chrome Version: Version 59.0.3071.25 dev (64-bit)
OS: Platform 9460.11.0 (Official Build) dev-channel tricky & Reks

What steps will reproduce the problem?

(1) Launch Chrome & Install the theme "City and Bridge in the Fog - Full HD - Axlg"
https://chrome.google.com/webstore/detail/city-and-bridge-in-the-fo/kdegpmcndhhenlehkilbepaihkaefkom?hl=en
Make sure the theme is applied correctly.

(2) Navigate to few websites & open a new tab. Make sure the Most visited thumbnails are shown.

(3) Remove a thumbnail. 

What is the expected result?
Thumbnail Removed. Undo Restore all options should be shown at the bottom of the Most visited thumbnails.

What happens instead?
Only X is shown when this theme is applied. 
Undo Restore all options are missing

Please find the attached screen shot.

 
IMG_3088.JPG
80.8 KB View Download
Labels: OS-Mac OS-Windows
Summary: Undo Restore all options are missing for removed thumbnail when City and Bridge in the Fog theme is applied (was: Undo Restore all options are missing when City and Bridge in the Fog theme is applied)
Not a regression issue as this is seen on Beta build # 58.0.3029.78 & Stable build # 57.0.2987.133 as well.

Comment 2 by r...@chromium.org, May 8 2017

Owner: rdevlin....@chromium.org
This seems related to themes. Over to Devlin to triage.

Cc: rdevlin....@chromium.org dbeam@chromium.org
Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)
themes -> pkotwicz@.
dbeam@, do you know who owns NTP nowadays?

Comment 4 by dbeam@chromium.org, May 10 2017

Cc: treib@chromium.org

Comment 5 by treib@chromium.org, May 10 2017

Components: UI>Browser>NewTabPage

Comment 6 by treib@chromium.org, May 10 2017

I looked into this: The "undo" and "restore all" options are still there and clickable, but they're invisible. That's because the theme sets the font color to transparent. So we can either call this "working as intended", or reduce the power of themes by e.g. enforcing some minimum opacity. But they could still set a color that's the same as the background, so this seems kinda futile.
I'm tempted to just "WontFix" this. WDYT?
Just my $0.02, but that (WontFix) sounds reasonable to me.  As you say, there's very little we can do to *effectively* enforce themes being unable to hide text like this, and there's significant diminishing returns.
Reproducible with the Santa Monica Ferris wheel theme as well.

https://chrome.google.com/webstore/detail/santa-monica-ferris-wheel/jkacmgdgemhedpcoiihkinfppnmapogi
Labels: -Pri-1 -M-59 Pri-3
Reducing priority and dropping target milestone based on comments #6 and #7.

Comment 10 by treib@chromium.org, Jan 11 2018

Cc: pkotw...@chromium.org
Labels: OS-Linux
Owner: ----
Status: WontFix (was: Assigned)
WontFixing per comments 6/7.

Sign in to add a comment