New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715289 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
User never visited
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Complete tilt plumbing from ui::Events to blink

Project Member Reported by tbuck...@chromium.org, Apr 25 2017

Issue description

Web developers should be able to access the tilt angle of the stylus via tiltX/tiltY properties.
 

Comment 1 by mustaq@chromium.org, Apr 26 2017

Mergedinto: 673586
Status: Duplicate (was: Assigned)
Cc: denniskempin@chromium.org
Components: Blink>Input
Labels: Hotlist-Input-Dev
Owner: mustaq@chromium.org
Status: Assigned (was: Duplicate)
Summary: Complete tilt plumbing from ui::Events to blink (was: Support tilt in Pointer Events)
Reopening, the other issue took care of the event path upto ui:Events.
Cc: jkwang@chromium.org
jkwang@ pointed to some missing links in ui:Events to WebInputEvent conversion in crbug.com/673586#c15.

Comment 4 Deleted

Comment 5 by jkwang@google.com, May 8 2017

https://codereview.chromium.org/2860793003/
A quick CL is here.
Will fix unittest.

Comment 6 by mustaq@chromium.org, May 16 2017

Owner: jkwang@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b0a0385c305c9dffc2cca15e3f58917ec245299

commit 0b0a0385c305c9dffc2cca15e3f58917ec245299
Author: jkwang <jkwang@google.com>
Date: Wed May 17 03:42:05 2017

Pass through tilt_x and tilt_y to blink

Tilt data was lost during event conversion. This patch fixes the code
path.

BUG= 715289 
TEST=Add log to ui event and compare it with javascript log of
event.tiltX and event.tiltY

Review-Url: https://codereview.chromium.org/2860793003
Cr-Commit-Position: refs/heads/master@{#472308}

[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/content/browser/renderer_host/input/motion_event_web.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/content/browser/renderer_host/input/motion_event_web.h
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/content/browser/renderer_host/input/motion_event_web_unittest.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/content/browser/renderer_host/input/web_input_event_builders_android.h
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/content/browser/renderer_host/input/web_input_event_util_unittest.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/android/motion_event_android.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/android/motion_event_android.h
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/android/motion_event_android_unittest.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/blink/blink_event_util.h
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/gesture_detection/motion_event.h
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/gesture_detection/motion_event_buffer_unittest.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/gesture_detection/motion_event_generic.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/gesture_detection/motion_event_generic.h
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/gestures/motion_event_aura.cc
[modify] https://crrev.com/0b0a0385c305c9dffc2cca15e3f58917ec245299/ui/events/test/motion_event_test_utils.cc

Project Member

Comment 8 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/424fd27db211d380ddc81f09f0f35b71661e6cdf

commit 424fd27db211d380ddc81f09f0f35b71661e6cdf
Author: jkwang <jkwang@google.com>
Date: Fri May 26 10:22:25 2017

Add tilt_x and tilt_y to ppapi touchpoint.

This patch adds tilt_x and tilt_y fields to pp_touch_point.

BUG= 715289 
TEST=

Review-Url: https://codereview.chromium.org/2890323002
Cr-Commit-Position: refs/heads/master@{#474977}

[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/api/ppb_input_event.idl
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/c/pp_macros.h
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/c/ppb_input_event.h
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/cpp/input_event.cc
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/cpp/touch_point.h
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/proxy/ppapi_messages.h
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/shared_impl/ppb_input_event_shared.cc
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/shared_impl/ppb_input_event_shared.h
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/thunk/interfaces_ppb_public_stable.h
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/thunk/ppb_input_event_api.h
[modify] https://crrev.com/424fd27db211d380ddc81f09f0f35b71661e6cdf/ppapi/thunk/ppb_input_event_thunk.cc

Comment 9 by jkwang@google.com, Jun 12 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment