New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715268 link

Starred by 1 user
Status: Fixed
Owner:
amaralp@chromium.org
Closed: Apr 2017
Cc:
█ ti...@chromium.org
█ aelias@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Floating Action Mode doesn't close

Project Member Reported by amaralp@chromium.org, Apr 25 2017 
Chrome Version: M59
OS: Android M+
What steps will reproduce the problem?
(1) Go to data:text/html,<div contenteditable></div>
(2) Type "enter/return" to get to a newline
(3) Type "backspace" to delete newline
(4) Long-press in empty textarea
(5) Click "Select All"
(6) Type something

What is the expected result?
Floating menu is still there

What happens instead?
Floating menu shouldn't be there
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae9712079d2b34e4a543a8f04de581a3b7bfd383

commit ae9712079d2b34e4a543a8f04de581a3b7bfd383
Author: amaralp <amaralp@chromium.org>
Date: Wed Apr 26 00:55:18 2017

Only start action mode if there is a selection

It currently doesn't make sense to have an action mode without a selection. The main
way to close the action mode is through |SELECTION_HANDLES_CLEARED| and that is not
possible in this situation since there was no selection to begin with.

BUG= 715268 

Review-Url: https://codereview.chromium.org/2836843006
Cr-Commit-Position: refs/heads/master@{#467186}

[modify] https://crrev.com/ae9712079d2b34e4a543a8f04de581a3b7bfd383/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Comment 2 by aelias@chromium.org, Apr 26 2017

Labels: Merge-Request-59 M-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 26 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b601128af8413ee77c17735df8a2475118d5bce2

commit b601128af8413ee77c17735df8a2475118d5bce2
Author: Alexandre Elias <aelias@chromium.org>
Date: Wed Apr 26 01:18:56 2017

Only start action mode if there is a selection

It currently doesn't make sense to have an action mode without a selection. The main
way to close the action mode is through |SELECTION_HANDLES_CLEARED| and that is not
possible in this situation since there was no selection to begin with.

BUG= 715268 

Review-Url: https://codereview.chromium.org/2836843006
Cr-Commit-Position: refs/heads/master@{#467186}
(cherry picked from commit ae9712079d2b34e4a543a8f04de581a3b7bfd383)

Review-Url: https://codereview.chromium.org/2842063003 .
Cr-Commit-Position: refs/branch-heads/3071@{#216}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/b601128af8413ee77c17735df8a2475118d5bce2/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Comment 5 by aelias@chromium.org, Apr 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment