Issue metadata
Sign in to add a comment
|
1%-707.2% regression in memory.top_10_mobile_stress at 466764:466853 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 25 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981307963216469328
,
Apr 25 2017
=== BISECT JOB RESULTS === Bisect failed for unknown reasons Please contact the team (see below) and report the error. Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : memory.top_10_mobile_stress Metric : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/foreground/http_m_intl_taobao_com_group_purchase_html Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981307963216469328 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5885808994680832 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 25 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981302447615263968
,
Apr 26 2017
=== Auto-CCing suspected CL author dgozman@chromium.org === Hi dgozman@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : dgozman Commit : 3b36efad6b17e10ae243a8668528aae310a312da Date : Mon Apr 24 23:47:21 2017 Subject: [DevTools] Consolidate overlay-related functionality in Overlay domain Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : memory.top_10_mobile_stress Metric : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/foreground/http_m_intl_taobao_com_group_purchase_html Change : 707.16% | 5356708.0 -> 43237268.0 Revision Result N chromium@466790 5356708 +- 0.0 6 good chromium@466817 5356708 +- 0.0 6 good chromium@466824 5356708 +- 0.0 6 good chromium@466825 5356708 +- 0.0 6 good chromium@466826 43237268 +- 0.0 6 bad <-- chromium@466827 43237268 +- 0.0 6 bad chromium@466830 43237268 +- 0.0 6 bad chromium@466843 43237268 +- 0.0 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981302447615263968 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5885808994680832 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 26 2017
Issue 715267 has been merged into this issue.
,
Apr 27 2017
,
Apr 27 2017
,
Apr 27 2017
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bf230386429b68cd02e0b1cb8450691f525fc04 commit 4bf230386429b68cd02e0b1cb8450691f525fc04 Author: dgozman <dgozman@chromium.org> Date: Fri Apr 28 08:01:32 2017 [DevTools] Cleanup overlay resources in Dispose This is a speculative attempt to fight memory regression after recent overlay refactoring. I suspect that InspectorOverlayAgent is retained either by InspectorOverlayHost or InspectorPageOverlayDelegate. This patch tries to clean them up in Dispose and ensure that nothing will be created after that point (disposed_ field). BUG= 715266 Review-Url: https://codereview.chromium.org/2850623002 Cr-Commit-Position: refs/heads/master@{#467927} [modify] https://crrev.com/4bf230386429b68cd02e0b1cb8450691f525fc04/third_party/WebKit/Source/core/inspector/InspectorOverlayHost.cpp [modify] https://crrev.com/4bf230386429b68cd02e0b1cb8450691f525fc04/third_party/WebKit/Source/core/inspector/InspectorOverlayHost.h [modify] https://crrev.com/4bf230386429b68cd02e0b1cb8450691f525fc04/third_party/WebKit/Source/web/InspectorOverlayAgent.cpp [modify] https://crrev.com/4bf230386429b68cd02e0b1cb8450691f525fc04/third_party/WebKit/Source/web/InspectorOverlayAgent.h
,
Apr 28 2017
Issue 715347 has been merged into this issue.
,
May 1 2017
All graphs have recovered by now. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rschoen@google.com
, Apr 25 2017