New issue
Advanced search Search tips

Issue 715260 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Move offline functions from Tab.java to OfflinePageUtils.java

Project Member Reported by jianli@chromium.org, Apr 25 2017

Issue description

We should move offline functions from Tab.java to OfflinePageUtils.java.
 

Comment 1 by jianli@chromium.org, Apr 25 2017

This is to address tedchoc's previous feedback.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc

commit f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc
Author: jianli <jianli@chromium.org>
Date: Tue Apr 25 22:35:47 2017

Move offline related functions from Tab to OfflinePageUtils

BUG= 715260 

Review-Url: https://codereview.chromium.org/2838773002
Cr-Commit-Position: refs/heads/master@{#467143}

[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/browser/android/offline_pages/offline_page_bridge.h
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc/chrome/browser/android/tab_android.h

Comment 3 by jianli@chromium.org, Apr 25 2017

Status: Fixed (was: Started)

Sign in to add a comment