New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715246 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Support IDS_ string cross-references from C++ to GRIT in cs.chromium.org

Project Member Reported by lgar...@chromium.org, Apr 25 2017

Issue description

What steps will reproduce the problem?
(1) Use code search to browse code that uses IDS_... strings [1]
(2) and click on a string like IDS_NOT_SECURE_VERBOSE_STATE in C++

What is the expected result?
See the `grd[p]` source definitions of the string in the list of cross-references.

What happens instead?
Get taken to resource ID definitions [2].

If I'm looking up a string, the resource ID is basically never what I want. But I very often want to jump between string definitions and their uses. For someone like me who regularly works on UI code, it would be very useful.
(And for someone who rarely works on UI code, it could avoid confusion.)

[1] https://cs.chromium.org/chromium/src/components/toolbar/toolbar_model_impl.cc?type=cs&q=%22l10n_util::GetStringUTF16(IDS_NOT_SECURE_VERBOSE_STATE)%22&l=125
[2] https://cs.chromium.org/chromium/src/out/Debug/gen/components/strings/grit/components_strings.h?type=cs&l=372
 

Comment 1 by emso@chromium.org, May 17 2017

Labels: Xrefs
Owner: emso@chromium.org
Status: Assigned (was: Untriaged)
I'm not very familiar with the code so I have trouble visualizing the behavior  you would like here. What does grd[p] mean and how is it different fromhttps://cs.chromium.org/chromium/src/out/Debug/gen/components/strings/grit/components_strings.h?rcl=c3cdacf5d7e659b11a48db98d1fc9b72257dbcd4&l=358 ?

Comment 3 by emso@chromium.org, May 18 2017

Labels: Lang
Ah, ok, I see. This is a special format.
Yep!

I'm aware this is probably a non-trivial feature request, but it would be very useful. :-)

Comment 5 by emso@chromium.org, Nov 2 2017

Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 2

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Untriaged)

Sign in to add a comment