New issue
Advanced search Search tips

Issue 715244 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 695734



Sign in to add a comment

Remove WebMediaPlayerClient::RequestReload

Project Member Reported by tguilbert@chromium.org, Apr 25 2017

Issue description

The addition of the RendererFactorySelector allows us to switch renderers types at runtime, rather than at WMPI creation time.

The RequestReload API introduced to handle redirected HLS in 618109 can therefore be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7473717100889a6245a01e3683215a64fe2aec1a

commit 7473717100889a6245a01e3683215a64fe2aec1a
Author: tguilbert <tguilbert@chromium.org>
Date: Tue May 02 20:18:38 2017

Remove WebMediaPlayerClient::RequestReload()

The WMPC::RequestReload() interface was introduced as part of the fix
for  crbug.com/618109 . The interface allows us to re-create an instance
of WMPI, if the final redirected URL is an HLS url.

The RendererFactorySelector allows us change Renderer types, after WMPI
has been created. This removes the need for a RequestReload interface.

BUG= 715244 

Review-Url: https://codereview.chromium.org/2844963006
Cr-Commit-Position: refs/heads/master@{#468758}

[modify] https://crrev.com/7473717100889a6245a01e3683215a64fe2aec1a/content/renderer/media/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/7473717100889a6245a01e3683215a64fe2aec1a/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/7473717100889a6245a01e3683215a64fe2aec1a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/7473717100889a6245a01e3683215a64fe2aec1a/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/7473717100889a6245a01e3683215a64fe2aec1a/third_party/WebKit/public/platform/WebMediaPlayerClient.h

Status: Fixed (was: Assigned)

Sign in to add a comment