New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715239 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 634542



Sign in to add a comment

Use CanvasColorParams in ImageData

Project Member Reported by zakerinasab@chromium.org, Apr 25 2017

Issue description


The current version of ImageData has redundant code to convert CanvasColorSpace and CanvasPixelFormat to SkColorSpace. Replace the redundant code with use of CanvasColorParams.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70d96a8266f71bb56e1cbbc54689b59d8eab5d40

commit 70d96a8266f71bb56e1cbbc54689b59d8eab5d40
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Jun 13 19:14:11 2017

Refactor ImageBitmap

This CL refactors ImageBitmap. It was essentially started to fix
ImageBitmap constructor from ImageData which was not correctly handling
ColorSpaceConversion attribute passed in ImageBitmapOptions. During the
developement it gradually extended to improving other constructors too.
(This CL is moved from Rietveld codereview.chromium.org/2845193002.)

BUG= 714649 , 683307 ,627855, 715264 , 715239 , 714364 , 686862 , 665919 

Change-Id: Iecba66e8764b189a4f5130096b4b5a19a9a32cae
Reviewed-on: https://chromium-review.googlesource.com/527690
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479093}
[modify] https://crrev.com/70d96a8266f71bb56e1cbbc54689b59d8eab5d40/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage-expected.txt
[modify] https://crrev.com/70d96a8266f71bb56e1cbbc54689b59d8eab5d40/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html
[modify] https://crrev.com/70d96a8266f71bb56e1cbbc54689b59d8eab5d40/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-out-of-bounds-src-expected.html
[modify] https://crrev.com/70d96a8266f71bb56e1cbbc54689b59d8eab5d40/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-recursive.html
[modify] https://crrev.com/70d96a8266f71bb56e1cbbc54689b59d8eab5d40/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js
[modify] https://crrev.com/70d96a8266f71bb56e1cbbc54689b59d8eab5d40/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/70d96a8266f71bb56e1cbbc54689b59d8eab5d40/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
[modify] https://crrev.com/70d96a8266f71bb56e1cbbc54689b59d8eab5d40/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/70d96a8266f71bb56e1cbbc54689b59d8eab5d40/third_party/WebKit/Source/core/html/ImageData.h

Status: Fixed (was: Assigned)
Blocking: 634542

Sign in to add a comment