[Findit] Fix grouping |
||||||||
Issue descriptionCurrently we group Findit analysis by failure info and heuristic results. This approach has some issues: 1. The grouping is not guaranteed to match SoM alerts 2. If analyses in the group have different results from swarming rerun or try jobs, the results would be inconsistent 3. For non-first-time-failures with only try job results, the grouping cannot link the culprits. We need to either fix issues in existing grouping or use the same grouping as SoM alerts. ⛆ |
|
|
,
May 1 2017
A new case in reported in https://bugs.chromium.org/p/chromium/issues/detail?id=717129. In this case 2 builds in the same group found the same culprit while another build found the failure is flaky. Sheriff reported the culprit was wrong. First thing we could do is to modify notification logic in this case, but eventually we need to fix grouping.
,
Jul 10 2017
,
Jul 17 2017
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9d2d79e1d9a783124aee71a9d3ac9ba8afa0c234 commit 9d2d79e1d9a783124aee71a9d3ac9ba8afa0c234 Author: Chan <chanli@chromium.org> Date: Fri Jul 21 20:19:31 2017 [Findit] Don't use group info when displaying analysis result. Bug: 715234 Change-Id: I494844c9db84b35b927371c359b8d69e107eb22a Reviewed-on: https://chromium-review.googlesource.com/578657 Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/9d2d79e1d9a783124aee71a9d3ac9ba8afa0c234/appengine/findit/handlers/handlers_util.py [modify] https://crrev.com/9d2d79e1d9a783124aee71a9d3ac9ba8afa0c234/appengine/findit/handlers/test/handlers_util_test.py
,
Jul 24 2017
,
Jul 31 2017
|
|||||
►
Sign in to add a comment |
||||||||
Comment 1 by chanli@chromium.org
, Apr 25 2017