New issue
Advanced search Search tips

Issue 715232 link

Starred by 1 user
Status: Fixed
Owner:
jbroman@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ValueSerializer should have documentation that warns about format changes near a branch.

Project Member Reported by jbroman@chromium.org, Apr 25 2017 
This contributed to bug 698214.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0f82f0d3a4a761a944bb4f5a4153ea2f062c0269

commit 0f82f0d3a4a761a944bb4f5a4153ea2f062c0269
Author: jbroman <jbroman@chromium.org>
Date: Thu Apr 27 15:39:23 2017

ValueSerializer: Add a warning about making wire format changes near branch.

BUG= chromium:715232 

Review-Url: https://codereview.chromium.org/2839903003
Cr-Commit-Position: refs/heads/master@{#44947}

[modify] https://crrev.com/0f82f0d3a4a761a944bb4f5a4153ea2f062c0269/src/value-serializer.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9f2d84e6e7e578e3b7f248184d6564d1f92c43f

commit f9f2d84e6e7e578e3b7f248184d6564d1f92c43f
Author: jbroman <jbroman@chromium.org>
Date: Thu Apr 27 17:53:39 2017

SerializedScriptValue: Add a warning about making wire format changes near branch.

BUG= 715232 

Review-Url: https://codereview.chromium.org/2844543002
Cr-Commit-Position: refs/heads/master@{#467732}

[modify] https://crrev.com/f9f2d84e6e7e578e3b7f248184d6564d1f92c43f/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h

Comment 3 by jbroman@chromium.org, Apr 27 2017

Status: Fixed (was: Started)
►

Sign in to add a comment