New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715192 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Disable unused skia vector icons on Android.

Project Member Reported by mthiesse@chromium.org, Apr 25 2017

Issue description

VR uses a small subset of the skia vector icons for its UI, so we should keep the ones we don't need disabled, as they previously were on Android.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/325ab947264549023c35565ca71fd5873a3d18c0

commit 325ab947264549023c35565ca71fd5873a3d18c0
Author: mthiesse <mthiesse@chromium.org>
Date: Wed Apr 26 05:02:30 2017

Disable unused skia icons for Android.

We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out.

This saves ~12KB in debug MonochromePublic builds.

BUG= 715192 

Review-Url: https://codereview.chromium.org/2844513003
Cr-Commit-Position: refs/heads/master@{#467236}

[modify] https://crrev.com/325ab947264549023c35565ca71fd5873a3d18c0/ui/vector_icons/BUILD.gn

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 26 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/259842d455b818e38f89a5a87d0ea0c6bcf04ee7

commit 259842d455b818e38f89a5a87d0ea0c6bcf04ee7
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Apr 26 14:17:30 2017

Disable unused skia icons for Android.

We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out.

This saves ~12KB in debug MonochromePublic builds.

BUG= 715192 

Review-Url: https://codereview.chromium.org/2844513003
Cr-Commit-Position: refs/heads/master@{#467236}
(cherry picked from commit 325ab947264549023c35565ca71fd5873a3d18c0)

Review-Url: https://codereview.chromium.org/2838413002 .
Cr-Commit-Position: refs/branch-heads/3071@{#224}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/259842d455b818e38f89a5a87d0ea0c6bcf04ee7/ui/vector_icons/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e85c66981e6d362d0f3d54ebbe84a6516ae081b5

commit e85c66981e6d362d0f3d54ebbe84a6516ae081b5
Author: mthiesse <mthiesse@chromium.org>
Date: Fri May 05 16:20:35 2017

Revert of Disable unused skia icons for Android. (patchset #1 id:1 of https://codereview.chromium.org/2844513003/ )

Reason for revert:
Patch is useless, reverting to reduce the complexity this adds.

Original issue's description:
> Disable unused skia icons for Android.
>
> We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out.
>
> This saves ~12KB in debug MonochromePublic builds.
>
> BUG= 715192 
>
> Review-Url: https://codereview.chromium.org/2844513003
> Cr-Commit-Position: refs/heads/master@{#467236}
> Committed: https://chromium.googlesource.com/chromium/src/+/325ab947264549023c35565ca71fd5873a3d18c0

TBR=sadrul@chromium.org,estade@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 715192 

Review-Url: https://codereview.chromium.org/2860883005
Cr-Commit-Position: refs/heads/master@{#469673}

[modify] https://crrev.com/e85c66981e6d362d0f3d54ebbe84a6516ae081b5/ui/vector_icons/BUILD.gn

Status: Fixed (was: Started)
Status: WontFix (was: Fixed)
Labels: Proj-VR-Shell

Sign in to add a comment