New issue
Advanced search Search tips

Issue 715178 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

usb_port_power: Number of ports are fixed

Project Member Reported by dnojiri@chromium.org, Apr 25 2017

Issue description

Currently, usb_port_power_dumb and usb_port_power_smart can control two and three ports, respectively.

usb_port_power_smart further restrict numbers of ports for ilim and mode to two.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/95139fa58280335f302827d96154038a7c23e0c0

commit 95139fa58280335f302827d96154038a7c23e0c0
Author: Daisuke Nojiri <dnojiri@chromium.org>
Date: Tue May 02 04:54:10 2017

usb_port_power: Allow variable number of ports

Currently, usb_port_power_dumb allows fixed number of ports (2)
and usb_port_power_smart allows less than 4 ports. This change
removes the limitation and makes them accept variable number of
ports.

BUG=chromium:715178
BRANCH=none
TEST=Verified usbchargemode returns consistent charge_mode across
sysjumps on Electro.

Change-Id: I7675c65ba03d3e6f7f53b2fe48cbe510231d945a
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/481077
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/95139fa58280335f302827d96154038a7c23e0c0/board/samus/board.c
[modify] https://crrev.com/95139fa58280335f302827d96154038a7c23e0c0/board/strago/board.c
[modify] https://crrev.com/95139fa58280335f302827d96154038a7c23e0c0/common/usb_port_power_dumb.c
[modify] https://crrev.com/95139fa58280335f302827d96154038a7c23e0c0/board/kahlee/board.c
[modify] https://crrev.com/95139fa58280335f302827d96154038a7c23e0c0/common/usb_port_power_smart.c
[modify] https://crrev.com/95139fa58280335f302827d96154038a7c23e0c0/board/reef/board.c

Status: Assigned (was: Untriaged)

Sign in to add a comment