New issue
Advanced search Search tips

Issue 715177 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 713345



Sign in to add a comment

Don't run mobile benchmarks on desktop bots

Project Member Reported by martiniss@chromium.org, Apr 25 2017

Issue description

We're running mobile benchmarks on desktop bots. It's both confusing, and does waste some time. They are usually disabled, so it's not a lot of time, but it is technically inefficient.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3854d7c235ea528280031646652e030092c0d9b5

commit 3854d7c235ea528280031646652e030092c0d9b5
Author: Stephen Martinis <martiniss@chromium.org>
Date: Tue Apr 25 19:22:08 2017

Fix disable/enable logic for mobile benchmarks

Some benchmarks use ShouldDisable to not run on android (or run on android).
This CL changes those to use decorators. This is so that we can statically
analyze our benchmarks (in later CLs).

Also adds a unittest for benchmarks with 'mobile' in the name.

Bug:  715177 
Change-Id: I611aa0e1924b640ec4a26bf1a8ff31813595daaf
Reviewed-on: https://chromium-review.googlesource.com/477473
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#467072}
[modify] https://crrev.com/3854d7c235ea528280031646652e030092c0d9b5/tools/perf/benchmarks/benchmark_unittest.py
[modify] https://crrev.com/3854d7c235ea528280031646652e030092c0d9b5/tools/perf/benchmarks/rasterize_and_record_micro.py
[modify] https://crrev.com/3854d7c235ea528280031646652e030092c0d9b5/tools/perf/benchmarks/v8_browsing.py

Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dda54d9447069a3c5dd62fc547ae71f6ff28766e

commit dda54d9447069a3c5dd62fc547ae71f6ff28766e
Author: Stephen Martinis <martiniss@chromium.org>
Date: Tue May 02 01:03:05 2017

Don't run unnecessary benchmarks on desktop perf bots

The chromium.perf desktop bots currently trigger jobs for all existing benchmarks,
even if the benchmark isn't supposed to be running on that specific platform. This CL
makes it so that desktop bots don't trigger tests which will never be run.

Bug:  715177 
Change-Id: I61caa4ad1a89e1d3f52349728ab67a7c9563885d
Reviewed-on: https://chromium-review.googlesource.com/477270
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#468517}
[modify] https://crrev.com/dda54d9447069a3c5dd62fc547ae71f6ff28766e/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/dda54d9447069a3c5dd62fc547ae71f6ff28766e/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/dda54d9447069a3c5dd62fc547ae71f6ff28766e/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/dda54d9447069a3c5dd62fc547ae71f6ff28766e/tools/perf/core/perf_data_generator_unittest.py

Status: Fixed (was: Started)
Ok, this should actually be done.

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment