New issue
Advanced search Search tips

Issue 715159 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Do not surface imageWidth/Height if values are 0.

Project Member Reported by mcasas@chromium.org, Apr 25 2017

Issue description

Report from the field:
> On a Chromebook, PhotoCapabilities imageWidth and imageHeight values are all set to 0 (min, max, step). [...] If so, we might want to remove it if it’s not supported.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57934e7bb8f2c9c787b61ee7f3b41dbc11f1760d

commit 57934e7bb8f2c9c787b61ee7f3b41dbc11f1760d
Author: mcasas <mcasas@chromium.org>
Date: Wed Apr 26 17:29:34 2017

Image Capture: don't set PhotoCapabilities width/height if min/max are both zero

This CL avoids setting PhotoCapabilities.{width,height} if the
platform has min/max values of zero, respectively.

BUG= 715159 

Review-Url: https://codereview.chromium.org/2839053002
Cr-Commit-Position: refs/heads/master@{#467364}

[modify] https://crrev.com/57934e7bb8f2c9c787b61ee7f3b41dbc11f1760d/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp

Comment 2 by mcasas@chromium.org, Apr 26 2017

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 27 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19b4bbb4c705074f52cf77b1d9a8f04e7fd9c2c3

commit 19b4bbb4c705074f52cf77b1d9a8f04e7fd9c2c3
Author: Miguel Casas-Sanchez <mcasas@chromium.org>
Date: Thu Apr 27 18:19:42 2017

Image Capture: don't set PhotoCapabilities width/height if min/max are both zero

This CL avoids setting PhotoCapabilities.{width,height} if the
platform has min/max values of zero, respectively.

BUG= 715159 

Review-Url: https://codereview.chromium.org/2839053002
Cr-Commit-Position: refs/heads/master@{#467364}
(cherry picked from commit 57934e7bb8f2c9c787b61ee7f3b41dbc11f1760d)

Review-Url: https://codereview.chromium.org/2844363002 .
Cr-Commit-Position: refs/branch-heads/3071@{#266}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/19b4bbb4c705074f52cf77b1d9a8f04e7fd9c2c3/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp

Comment 5 by mcasas@chromium.org, Apr 27 2017

Status: Fixed (was: Assigned)

Sign in to add a comment