New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715154 link

Starred by 0 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Apr 2017
Cc:
fhorschig@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

components/doodle: Support birthday doodles

Project Member Reported by treib@chromium.org, Apr 25 2017 
This requires authentication towards the doodle API. For now, we'll use cookies for that (simplest), but mid-term we should switch to OAuth2 instead, for two reasons:
- With OAuth, birthday doodles will be tied to Chrome sign-in rather than content area sign-in (on Android with account consistency, it doesn't matter much, but it will matter on desktop).
- Cookie auth won't work on iOS, see bug 711314.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29b3b5cf99713f88fd9b5739dcbb2f476e2721e0

commit 29b3b5cf99713f88fd9b5739dcbb2f476e2721e0
Author: treib <treib@chromium.org>
Date: Wed Apr 26 10:32:35 2017

[Doodle] Allow cookie authentication

This enables birthday doodles.

BUG= 715154 

Review-Url: https://codereview.chromium.org/2838713003
Cr-Commit-Position: refs/heads/master@{#467290}

[modify] https://crrev.com/29b3b5cf99713f88fd9b5739dcbb2f476e2721e0/components/doodle/doodle_fetcher_impl.cc

Comment 2 by treib@chromium.org, Apr 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment