New issue
Advanced search Search tips

Issue 715152 link

Starred by 1 user
Status: Fixed
Owner:
petewil@chromium.org
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 712941


Sign in to add a comment

Add a prerendrering offliner unit test for archiver returning ALREADY_EXISTS

Project Member Reported by petewil@chromium.org, Apr 25 2017 
in  crbug.com/704726 , we added a feature where we convert the MHTML page already existing to success.  We should add a unit test for this.  However, prerenderer unit tests are currently disabled as flaky.  ( crbug.com/712941 ).  We should re-enable the tests before adding this new test.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d33a171b7c308a64dc3372fac3da2179c63b419e

commit d33a171b7c308a64dc3372fac3da2179c63b419e
Author: petewil <petewil@chromium.org>
Date: Fri Apr 28 23:36:11 2017

Add a unit test for "ALREADY_SAVED" being converted to "SUCCESS"

We recently made a change to treat the MHTML page already being saved to
success, and we added a unit test for the background loader offliner,
but didn't add one for the prerendering offliner.  This adds the test
for the prerendering offliner.

BUG= 715152 

Review-Url: https://codereview.chromium.org/2850953002
Cr-Commit-Position: refs/heads/master@{#468181}

[modify] https://crrev.com/d33a171b7c308a64dc3372fac3da2179c63b419e/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Comment 2 by petewil@chromium.org, Apr 28 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment