New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715120 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Compat



Sign in to add a comment

Multi touch stops working when first touch drags.

Reported by neilcl...@gmail.com, Apr 25 2017

Issue description

Steps to reproduce the problem:
1. Put a finger on the screen
2. Quickly move it back and forth
3. Put another finger on the screen

What is the expected behavior?
Register a touch event.

What went wrong?
Chrome currently registers no subsequent touch events after the first touch quickly drags back and forth.

Did this work before? N/A 

Chrome version: 57.0.2987.137  Channel: stable
OS Version: 10.3.1
Flash Version: 

Use these pages to test : 

http://tomicloud.com/2012/03/multi-touch-demo
http://phaser.io/examples/v2/input/multi-touch
 

Comment 1 by sczs@chromium.org, May 17 2017

Cc: eugene...@chromium.org
Components: -UI UI>Browser>WebUI
Owner: michaeldo@chromium.org
Status: Assigned (was: Unconfirmed)
michaeldo@ could you please take a quick look or re-assign as you see fit
Components: -UI>Browser>WebUI Mobile>WebView>Glue
Cc: danyao@chromium.org
Labels: -Type-Bug Type-Compat
Cc: jif@chromium.org
This has a very similar root cause as  crbug.com/699655 . I can fix this by not executing the contents of the setWebViewInteractionEnabled: method in overscroll_actions_controller.mm

Every time a user scrolls, we disable interaction with the webView. I think this is overly aggressive. Maybe we should only disable interaction if the OverscrollState == STARTED_PULLING or ACTION_READY. I have this change in a test CL here: 

Adding jif@ as he looked into the other bug as well.

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feecd1919ed0b1e35e8262f540cf884e8719adc7

commit feecd1919ed0b1e35e8262f540cf884e8719adc7
Author: michaeldo <michaeldo@chromium.org>
Date: Fri Jun 09 16:11:59 2017

Enable multiple touch in WebView.

WebView touches are aggressively disabled by the
overscroll_actions_controller once a single touch begins to move. This
seems unnecessary and it breaks multi-touch within the webView.

TEST=See bug for replication steps to test multitouch. Also ensure
overscroll actions perform as expected, ensure that user interaction
with the webpage does not occur while the overscroll actions are
visible. Ex: Pull to refresh.
BUG= 715120 

Review-Url: https://codereview.chromium.org/2924903003
Cr-Commit-Position: refs/heads/master@{#478298}

[modify] https://crrev.com/feecd1919ed0b1e35e8262f540cf884e8719adc7/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

Cc: linds...@chromium.org
Status: Fixed (was: Assigned)
Lindsay, could you please ask someone to verify the fix, while Mike is out.
Cc: shbarezer@chromium.org
Hi Sharon, Can you please verify the fix? Thanks!
Status: Verified (was: Fixed)
Verified in 63.0.3225.0 Canary, iPhone 6 iOS 10.3.3, iPhone 7 iOS11

Chrome registers subsequent touch events.
Looks good.

Sign in to add a comment