New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715116 link

Starred by 1 user
Status: Duplicate
Merged: issue 223694
Owner:
senorblanco@chromium.org
Closed: Apr 2017
Cc:
█ junov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 701975



Sign in to add a comment

Performance degrades with context2D scale on line drawing

Project Member Reported by fs...@chromium.org, Apr 25 2017 
On the example page,

Setting ctx.scale(factor, factor) where factor is (for highdpi) 2 or 4, makes the FPS drop from 60 to 25 for line drawing. This is in a canvas that has the same pixel width/height.

Maybe there's something we can do about Skia's line/antialiasing algorithm and this case.
canvas-scale.html
2.5 KB View Download

Comment 1 by senorblanco@chromium.org, Apr 25 2017 

This is probably a dupe of 223694.

Lines <= 1 px in width get the "hairline" treatment in Skia, but >1px must be considered stroked lines, checked for self-intersections, etc.

Comment 2 by fs...@chromium.org, Apr 25 2017

Mergedinto: 223694
Status: Duplicate (was: Available)
Update the original title, merged.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df18b96b443774d232e39ead6cbd81c848b8563c

commit df18b96b443774d232e39ead6cbd81c848b8563c
Author: Stephen White <senorblanco@chromium.org>
Date: Mon Jun 18 20:54:43 2018

Adjust the edge-AA tessellator maximum verb count.

Increasing the verb count from 10 to 100 in Skia's edge-AA tessellating
path renderer improves performance on many tests, including
Animometer's Canvas Stroke Paths and the bugs listed below.

Bug:  805031 ,  223694 ,  715116 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I57d775ddce3200e5f54bae448de9fd2dffe30e72
Reviewed-on: https://chromium-review.googlesource.com/1099564
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568155}
[modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/skia/config/SkUserConfig.h
[modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/imagemap-overflowing-polygon-focus-ring-expected.png
[modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/imagemap-polygon-focus-ring-expected.png
[modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png
[modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png
[add] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-connecting-line-expected.png
[modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/downsample-quality-expected.png
►

Sign in to add a comment